-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac build is broken (permissions, symlinks, ... something else) #87
Comments
It's true that I don't own any macs, but I did test the |
To add to that, I just want to find out why not just double-click the |
thank you for both generally attempting to ship binaries for platforms you don’t have and for making attempts to test when you can
Not sure why things went differently for me than in your test
In the meantime I’ve tried out qutebrowser and am pretty happy with it so far, so 🤷♂️
explain why you would extract a .app in the first place, as that isn't clear at to me.
But I wanted to go ahead and respond to this, just for the sake of your mental model:
`.app`’s are always* folders; the file navigator (Finder) and launcher (Dock) treat them as though they were (packaged) executables when you open them (click in Dock, double click or Cmd-O in Finder), but they are not archives
(they may have some extended fs attributes indicating their type, I’m not sure, but I think it’s just the extension; Regardless... )
If you interact with them on the CLI, you will find they are just directories. (If you are inclined, eg for a script, you can execute them
as Finder does by running the `open` command on them; conversely if you right-click on a .app in Finder there is “Show Package Contents” that opens it as a dir)
I didn’t go into internals until after it failed to open ~naively (I _did_ do the right click > Open override to bypass signature checking
(“Gatekeeper”))
The only thing I extracted was the `.zip`
*I wouldn’t be shocked if the OS had some allowance for compressed `.app`s, but they definitely aren’t normal, I’ve never seen one that I remember
|
(As you can surmise I wrote the reply to your first comment without seeing your second comment; but my point stands: I tried to open it as normal first; I looked inside only after that failed) |
I tried again (cause otherwise I am just being a fanboy-cultist and half-watching the currently ongoing first arm macs press conference) and it seems like something is fishy about the zip
whereupon: |
It helps to know that it really is just a folder, which I kind of assumed already, but wasn't a 100% sure about, so I apologize for not being clear about that. Now I understand why you would starting inspecting the internals of the |
I did find these electron builder issues: |
Okay, so I pushed some code that will zip the mac build using a separate |
I have tested this myself due to the lack of response from @donaldguy and it works, given that you do the usual trickery mentioned here. The next 3.0.0 release will be the first to again work on mac. |
Whatever you are doing to export the build is spitting out "git style" symlinks (flat files with the path name) inside
Vieb.app/Contents/Frameworks/*.framework
(both the./Foo -> ./Versions/Current/Foo
and the./Versions/Current -> ./Versions/A
links)the Vieb binary itself (
Vieb.app/Contents/MacOS/Vieb
) was not executable, and is linked to those "symlink" paths rather than the specific versionsI
chmod +x
ed and fixed the symlinks, and I get some variety of handled exception still:crash information
I doubt this will mean all that much to you more than me, since I gather you aren't a mac owner.
Anyway - I might give a look at your build process sometime this week or weekend and see if I can figure it out, but no promises
Looking forward to trying out your app!
(In the error output above you can see/intuit a couple things. I am running with System Integrity Protection disabled because I am trying out the i3-ish tiling window manager https://github.com/koekeishiya/yabai and was doing my debigging from in https://sw.kovidgoyal.net/kitty/ – people who do these are the mac users you'd maybe attract; people playing with these toolchains currently gravitate towards https://qutebrowser.org but I am as skeptical of using a weird rendering engine vs normal Blink or Webkit)
EDIT: I want to acknowledge that QtWebEngine is a ~soft fork of Chromium and thus more normal than I thought, maybe as normal as using Electron but anyway. As a Mac and generally-GUI-y-less-Linux user can't say I keep up with Qt goings on
The text was updated successfully, but these errors were encountered: