Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Saving #19

Closed
anthonylavado opened this issue Jan 30, 2023 · 8 comments · Fixed by #22
Closed

Progress Saving #19

anthonylavado opened this issue Jan 30, 2023 · 8 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@anthonylavado
Copy link

Hey there!
I don't think I've seen this mentioned yet, but is progress saving in the works?

@Kara-Zor-El
Copy link
Member

Hi,

It already saves the books progress to the device, do you mean like saving it to the server for usage on other devices/clients?

@anthonylavado
Copy link
Author

Hrm. It wasn't saving progress locally for me earlier. It always just says no book/comics have been started.

@Kara-Zor-El
Copy link
Member

do you happen to know what filetypes the books/comics you've tried reading are?

@Kara-Zor-El
Copy link
Member

Additionally, what device/devices are you using. a little more info would be helpful

@anthonylavado
Copy link
Author

I'm so sorry - as a maintainer I should have known to give more info.

It's an .ePub, and I'm using an iPhone 12 Pro running iOS 16.3.

The Jellyfin server is running 10.8.9, the latest.

@Kara-Zor-El Kara-Zor-El added the bug Something isn't working label Feb 5, 2023
@Kara-Zor-El
Copy link
Member

I just tested on my end as well, that seems to be the case when running .ePub files.

I will get started on reworking that to improve the .ePub experience (I'll finally add image support to it as well hopefully)

@Kara-Zor-El Kara-Zor-El linked a pull request Feb 12, 2023 that will close this issue
@Kara-Zor-El Kara-Zor-El reopened this Feb 12, 2023
@Kara-Zor-El
Copy link
Member

Kara-Zor-El commented Feb 12, 2023

Hi, I added image support and continue reading support but epub files have proven to be a pain to deal with. I will continue to leave this open for the time being as I do not feel satisfied with my work but I will try to fix up the current system or improve it with a different system

I will also add this in the where to contribute section of the wiki to encourage others to take a shot at this

@Kara-Zor-El
Copy link
Member

I think this may be in a good idea to close this for the time being. I have added the stuff needed but am planning to do a full rewrite of the ePub reader soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants