fix fan speed in argon-status #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
error from sys logs:
Dec 30 21:19:58 argoneon sudo[60901]: pam_unix(sudo:session): session closed for user root Dec 30 21:20:00 argoneon python3[60906]: Exception in thread Thread-2 (temp_check): Dec 30 21:20:00 argoneon python3[60906]: Traceback (most recent call last): Dec 30 21:20:00 argoneon python3[60906]: File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner Dec 30 21:20:00 argoneon python3[60906]: self.run() Dec 30 21:20:00 argoneon python3[60906]: File "/usr/lib/python3.10/threading.py", line 953, in run Dec 30 21:20:00 argoneon python3[60906]: self._target(*self._args, **self._kwargs) Dec 30 21:20:00 argoneon python3[60906]: File "/etc/argon/argononed.py", line 252, in temp_check Dec 30 21:20:00 argoneon python3[60906]: setFanSpeed (instantaneous = False) Dec 30 21:20:00 argoneon python3[60906]: File "/etc/argon/argononed.py", line 244, in setFanSpeed Dec 30 21:20:00 argoneon python3[60906]: bus.write_byte(ADDR_FAN,newspeed) Dec 30 21:20:00 argoneon python3[60906]: TypeError: 'float' object cannot be interpreted as an integerFixing above error then created this error due to converting string rep of float straight to int:
Traceback (most recent call last): File "/usr/bin/argon-status", line 59, in <module> printTable({"Speed %" : getCurrentFanSpeed()} File "/etc/argon/argononed.py", line 197, in getCurrentFanSpeed return int(speed.read_text()) ValueError: invalid literal for int() with base 10: '30.0'