fix get_fanspeed function. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_fanspeed function scans a list of temperatures, and looks for the best match for the current temperature passed in and the corresponding fanspeed. The code had an issue where if the fanspeed was less than 25, it returned 25% all the time. So if you had a minimum temp value of say 35 degrees and a fan speed of 0, the function would return a fanspeed of 25% all the time. This has been eliminated. Also the temp_check function has been updatd to read in the configuration file EVERY SINGLE TIME so that we can now tweek the fan speeds on the fly. Once a change is made, approximately 30 seconds later the corresponding change will be made to the fan. Note in situations where the new fan speed is lower, it will take an additional 30 seconds to respond as the code is attemping to remove fluxuations in fan speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_fanspeed function scans a list of temperatures, and
looks for the best match for the current temperature passed in and
the corresponding fanspeed.
The code had an issue where if the fanspeed was less than 25, it
returned 25% all the time. So if you had a minimum temp value of say
35 degrees and a fan speed of 0, the function would return a fanspeed of
25% all the time. This has been eliminated.
Also the temp_check function has been updatd to read in the
configuration file EVERY SINGLE TIME so that we can now tweek the fan
speeds on the fly. Once a change is made, approximately 30 seconds
later the corresponding change will be made to the fan. Note in
situations where the new fan speed is lower, it will take an additional
30 seconds to respond as the code is attemping to remove fluxuations in
fan speed.