Fix types compatibility with React 19 #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa51804 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
I tested https://pkg.csb.dev/JedWatson/react-select/commit/ed73fc2e/react-select and it seems to work (both type checking and at runtime) |
Methuselah96
approved these changes
Nov 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5911.
React 19 removes the
JSXtype from the global scope, so it now needs to be imported fromReact.This causes some immediate issues for the users of react-select who are trying to use it with
@types/react@19, since theSelecttypes relies on theJSX.LibraryManagedAttributestype.Note that this is technically a breaking change because it requires TypeScript users to have a version of
@types/reactafter DefinitelyTyped/DefinitelyTyped#64464 shipped.(recreates #5912)