New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear button displays even when value is an empty string #2073

Closed

mariegodon opened this issue Oct 19, 2017 · 1 comment

mariegodon commented Oct 19, 2017 •

edited

Loading

As a result of #1394, the clear button now appears even when value is and empty string. This is also present in 1.0.0 release candidate.

This is confusing since there is the placeholder displayed with the clear button, which doesn't make sense, as shown in image below.

mariegodon mentioned this issue

do not show clear button if value is an empty string #2074

Merged

Author

mariegodon commented Oct 19, 2017

Implemented #2074 as potential fix

JedWatson closed this as completed in #2074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment