Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps #48

Merged
merged 10 commits into from
Oct 22, 2024
Merged

update deps #48

merged 10 commits into from
Oct 22, 2024

Conversation

gabriel-v
Copy link
Contributor

Scylla v0.14 and all of the others

Added new dev dependency for running all the tests that were starting with "truncate table" serially instead of in parallel ( i got some errors until i figured out to run with --test-thread=1 )

Copy link
Owner

@Jasperav Jasperav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! If you made the changes to the dependency and bump the Cargo.toml, I will publish the new version.

proc-macro2 = "1"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
scylla = "0.14.0" # This crate is specifically build for this version
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specific version dependency is fine, for the others, please remove the patch version :) so x.y and not x.y.z

@gabriel-v
Copy link
Contributor Author

ok

bumped workspace version 0.2.0, there are breaking changes:

  • select_paged has different argument type
  • the "Cursor" pub typedef was not used anymore

@Jasperav
Copy link
Owner

@gabriel-v LGTM, do you know why this error occurs on the CI? https://github.com/Jasperav/Catalytic/actions/runs/11437836428/job/31829718889?pr=48. If the CI is ok, I will publish the new version!

@gabriel-v
Copy link
Contributor Author

here you go

https://github.com/gabriel-v/Catalytic/actions/runs/11445259484

errors in order:

  • cargo lock version = 4 was from my local nightly compiler, when switched to stable, it now outputs version = 3
  • muted some clippy errors about comment string formatting, unrelated to patch
  • muted clippy error on dead code (Field::attribute, undocumented, for macro?) - plz review
  • removed "... and type is not null" from materialized view example - this errors (as type is not PK) in scylla >5.4.X, 6.x but not scylla 5.2.X nor cassandra 3.11
  • updated CI compiler toolchain to the newer one i had locally, since the compiler error text tests depend closely on compiler version (different structs implementing missing trait get printed)

@Jasperav Jasperav merged commit 120e392 into Jasperav:master Oct 22, 2024
1 check passed
@Jasperav
Copy link
Owner

Thanks a lot @gabriel-v, I published the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants