Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-ups::YouTube Videos submitted through bookmarklet are not playing on the pop-ups. #998

Open
jdaKoko opened this issue Sep 23, 2015 · 1 comment
Assignees

Comments

@jdaKoko
Copy link

jdaKoko commented Sep 23, 2015

@meeshmon @rchen152
Rebecca fixed the video problems with issue #887, however similar problems have been occurring again.
YouTube videos submitted through the bookmarklet are not playing in the pop-ups (as shown in the red box in the image below) and thumbnail images (yellow box) do not appear on the JDA site either. These videos play on Waku, so I would like to keep the admin page uris and attribution uris as they are.
I do not know how to phrase it but does it have to do something with the code for video bookmarklets and the pop-ups?

For example,
http://jdarchive.org/admin/zeega/data/item/1993962/edit
screen shot 2015-09-23 at 12 31 15 pm

The video works without a problem in Waku.
waku_flyjin_http jdarchive org en collection 1993336

@rchen152 rchen152 self-assigned this Sep 23, 2015
@rchen152
Copy link

rchen152 commented Oct 5, 2015

The reason for this is that some YouTube videos submitted through the bookmarklet have layer type "outside-YouTube" rather than "YouTube". Pull request #1001 fixes this for some items (e.g., http://jdarchive.org/admin/zeega/data/item/1990819/edit), but other videos (see http://jdarchive.org/admin/zeega/data/item/1992627/edit) are still not playing - need to look into this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants