refactor: remove admin-ui manifests from core #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jans-auth-server and jans-config-api are updated to support the new deployment strategy where admin-ui manifests are no longer shipped with core.
|
[jans-cli] Kudos, SonarCloud Quality Gate passed!
|
mo-auto
added
area-documentation
|
[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!
|
|
[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!
|
moabu
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
janssenproject/auth-serverandjanssenproject/config-apiimages are updated to support the new deployment strategy where admin-ui manifests are no longer shipped with core.Implementation Details
admin-uiplugin integration injanssenproject/config-api, thegluufederation/admin-uiimage container must be deployed upfront (contains required manifests i.e. persistence entry and application properties)Documentation
The following environment variables to populate admin-ui credentials are removed (in favor of user inputs via
admin-uiinterface)CN_LICENSE_ADMIN_UI_API_KEYCN_LICENSE_ADMIN_UI_PRODUCT_CODECN_LICENSE_ADMIN_UI_SHARED_KEYCN_LICENSE_ADMIN_UI_MANAGEMENT_KEYThe following environment variables to configure admin-ui clients are removed (should be configured in admin-ui image)
CN_TOKEN_SERVER_BASE_HOSTNAMECN_TOKEN_SERVER_AUTHZ_ENDPOINTCN_TOKEN_SERVER_TOKEN_ENDPOINTCN_TOKEN_SERVER_INTROSPECTION_ENDPOINTCN_TOKEN_SERVER_USERINFO_ENDPOINTCN_TOKEN_SERVER_CLIENT_IDCN_TOKEN_SERVER_CERT_FILE