Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-api): discrepancies in the api #2211

Closed
moabu opened this issue Aug 23, 2022 · 1 comment · Fixed by #2216
Closed

fix(config-api): discrepancies in the api #2211

moabu opened this issue Aug 23, 2022 · 1 comment · Fixed by #2216
Assignees
Labels
kind-bug Issue or PR is a bug in existing functionality

Comments

@moabu
Copy link
Member

moabu commented Aug 23, 2022

While reviewing the API and the response that is returned by the server, I noticed some discrepancies:

Following attributes were returned by the server, but are not defined in the API:

ParEndpoint
RequirePar
RequireRequestObjectEncryption
RequirePkce
AllowAllValueForRevokeEndpoint
StatAuthorizationScope
PublicSubjectIdentifierPerClientEnabled
SubjectIdentifiersPerClientSupported
AuthorizationSigningAlgValuesSupported
AuthorizationEncryptionAlgValuesSupported
AuthorizationEncryptionEncValuesSupported
ForceSignedRequestObject
GrantTypesAndResponseTypesAutofixEnabled
IncludeSidInResponse
IntrospectionSkipAuthorization
DcrAuthorizationWithMTLS
CibaEndUserNotificationConfig
DpopSigningAlgValuesSupported
DpopTimeframe
DpopJtiCacheTime
Fapi
AllResponseTypesSupported

While the attributes below are defined in the API, but were not returned by the server:

allowSpontaneousScopes
dynamicRegistrationAllowedPasswordGrantScopes
dynamicRegistrationCustomObjectClass
personCustomObjectClassList
statWebServiceIntervalLimitInSeconds
legacyDynamicRegistrationScopeParam
dcrSignatureValidationJwks
imgLocation
softwareStatementValidationClaimName
jmsBrokerUriSet
sessionIdEnabled
keyAlgsAllowedForGeneration
jsLocation
dcrSignatureValidationSoftwareStatementJwksUriClaim
staticKid
cssLocation
backchannelAuthenticationRequestSigningAlgValuesSupported
enabledOAuthAuditLogging
backchannelClientId
externalLoggerConfiguration
discoveryDenyKeys
discoveryAllowedKeys
dcrSignatureValidationJwksUri
enabledComponents
httpLoggingExcludePaths
jmsUserName
dcrSignatureValidationSharedSecret
oxElevenTestModeToken
dcrSignatureValidationSoftwareStatementJwksClaim
cookieDomain
jmsPassword

None of the attributes above were found in the UI.

Further inconsistency were observed:

  • According to the API ResponseTypesSupported is supposed to be an array of strings, however, the JSON contains an array of array of strings.
  • In the API, we have the attribute AllowIdTokenWithoutImplicitGrantTypes, while the JSON contains AllowIdTokenWithoutImplicitGrantType.
@moabu moabu self-assigned this Aug 23, 2022
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Aug 23, 2022
@moabu moabu assigned pujavs and unassigned moabu Aug 23, 2022
@pujavs
Copy link
Contributor

pujavs commented Aug 24, 2022

Synched swagger config with Auth App Config AppConfiguration.java

Following attributes were returned by the server, but are not defined in the API:

ParEndpoint - added
RequirePar - added
RequireRequestObjectEncryption - added
RequirePkce - added
AllowAllValueForRevokeEndpoint - added
StatAuthorizationScope -added
PublicSubjectIdentifierPerClientEnabled - added
SubjectIdentifiersPerClientSupported - added
AuthorizationSigningAlgValuesSupported - added
AuthorizationEncryptionAlgValuesSupported -added
AuthorizationEncryptionEncValuesSupported -added
ForceSignedRequestObject - added
GrantTypesAndResponseTypesAutofixEnabled - added
IncludeSidInResponse -added
IntrospectionSkipAuthorization - added
DcrAuthorizationWithMTLS - added
CibaEndUserNotificationConfig - already there
DpopSigningAlgValuesSupported - added
DpopTimeframe -added
DpopJtiCacheTime -added
Fapi - no field named only Fapi there is fapiCompatibility field which is already there
AllResponseTypesSupported - no field named only

For attributes below are defined in the API, but were not returned by the server:


allowSpontaneousScopes  - present in Auth AppConfiguration and hence not removed
dynamicRegistrationAllowedPasswordGrantScopes  - present in Auth AppConfiguration and hence not removed
dynamicRegistrationCustomObjectClass  - present in Auth AppConfiguration and hence not removed
personCustomObjectClassList   - present in Auth AppConfiguration and hence not removed
statWebServiceIntervalLimitInSeconds  - present in Auth AppConfiguration and hence not removed
legacyDynamicRegistrationScopeParam - removed
dcrSignatureValidationJwks  - present in Auth AppConfiguration and hence not removed
imgLocation - present in Auth AppConfiguration and hence not removed
softwareStatementValidationClaimName - present in Auth AppConfiguration and hence not removed
jmsBrokerUriSet - present in Auth AppConfiguration and hence not removed
sessionIdEnabled - removed
keyAlgsAllowedForGeneration - present in Auth AppConfiguration and hence not removed
jsLocation - present in Auth AppConfiguration and hence not removed
dcrSignatureValidationSoftwareStatementJwksUriClaim - present in Auth AppConfiguration and hence not removed
staticKid - present in Auth AppConfiguration and hence not removed
cssLocation - present in Auth AppConfiguration and hence not removed
backchannelAuthenticationRequestSigningAlgValuesSupported - present in Auth AppConfiguration and hence not removed
enabledOAuthAuditLogging - present in Auth AppConfiguration and hence not removed
backchannelClientId - present in Auth AppConfiguration and hence not removed
externalLoggerConfiguration - present in Auth AppConfiguration and hence not removed
discoveryDenyKeys - present in Auth AppConfiguration and hence not removed
discoveryAllowedKeys - present in Auth AppConfiguration and hence not removed
dcrSignatureValidationJwksUri - present in Auth AppConfiguration and hence not removed
enabledComponents - present in Auth AppConfiguration and hence not removed
httpLoggingExcludePaths - present in Auth AppConfiguration and hence not removed
jmsUserName - present in Auth AppConfiguration and hence not removed
dcrSignatureValidationSharedSecret - present in Auth AppConfiguration and hence not removed
oxElevenTestModeToken - present in Auth AppConfiguration and hence not removed
dcrSignatureValidationSoftwareStatementJwksClaim - present in Auth AppConfiguration and hence not removed
cookieDomain  - present in Auth AppConfiguration and hence not removed
jmsPassword - present in Auth AppConfiguration and hence not removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants