Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jans client api update seleniumhq version from 3.x to 4.x #2110

Merged

Conversation

jmunozherbas
Copy link
Contributor

@jmunozherbas jmunozherbas commented Aug 12, 2022

Prepare


Description

Solving issue to compile jans-client-api, due to SeleniumTestUtils issue:2047
Upgrading selenium version to 4.4.0 issue:1856

Target issue

#2047
#1856

closes #2047
closes #1856

Implementation Details

jans-client-api-common now compiles a test jar.
selenium dependencies was upgraded


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added the comp-jans-client-api Component affected by issue or PR label Aug 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2022

[jans-client-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jmunozherbas jmunozherbas marked this pull request as ready for review August 12, 2022 08:40
@yuriyz yuriyz merged commit d48271e into main Aug 12, 2022
@yuriyz yuriyz deleted the fix-jans-client-api-update-seleniumhq-version-from-3.x-to-4.x branch August 12, 2022 09:24
ossdhaval pushed a commit that referenced this pull request Aug 16, 2022
* fix(jans-client-api):upgrade seleniumhq to 4.4.0 and removing SeleniumTestUtils error

* fix(jans-client-api):remove setRequireAuthTime in operations and tests

* fix(jans-client-api):remove setRequireAuthTime assert from RegisterRequestMapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-client-api Component affected by issue or PR
Projects
None yet
3 participants