Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a workaround for fido2 dependency #1590

Merged
merged 2 commits into from
Jun 23, 2022
Merged

fix: a workaround for fido2 dependency #1590

merged 2 commits into from
Jun 23, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jun 22, 2022

Prepare


Description

Target issue

Ref: #1588

Implementation Details

Added Fido2 client as a workaround (as mentioned here)

@iromli iromli requested a review from moabu as a code owner June 22, 2022 20:55
@mo-auto mo-auto added comp-docker-jans-auth-server kind-bug Issue or PR is a bug in existing functionality labels Jun 22, 2022
Comment on lines 89 to 90
# A workaround for Fido2 integration
# @TODO: possibly will be removed (depends on https://github.com/JanssenProject/jans/issues/1499)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like its not a workaround any more. GluuFederation/flex#263

docker-jans-auth-server/scripts/entrypoint.sh Show resolved Hide resolved
@moabu moabu merged commit 527c928 into main Jun 23, 2022
@moabu moabu deleted the cn-fido2-client branch June 23, 2022 04:40
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-docker-jans-auth-server kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(docker-image): unable to login using OTP/FIDO2
3 participants