Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning when disabling export on elements when using the "Java Block/Item" format #2567

Open
LelouBil opened this issue Nov 26, 2024 · 3 comments

Comments

@LelouBil
Copy link

What are you trying to do, and what do you expect to happen?

While editing a file in the "Java Block/Item" format, I disable a group of elements from the export.
I then save the file.
I expect a warning that my "disabled" elements are in fact completely absent in the "save" because for this format, saving is exporting

What happens instead?

I get no warning, and can close and reopen blockbench at a later time and find my elements missing

Model format in which the issue occurs

Java Block/Item

Blockbench variant

Program

Blockbench version

4.11.2

Operating System

Windows 10

Installed Blockbench plugins

No response

@LelouBil LelouBil changed the title Issue Summary No warning when disabling export on elements when using the "Java Block/Item" format Nov 26, 2024
@LelouBil
Copy link
Author

I guess this also applies to any properties that the format doesn't support. Hiding/showing elements also doesn't persist on save, due to the format. Blockbench should maybe disable these features for formats that don't support them (or show a warning for features that do not actually change data, like visibility, that it will not be persisted when saving) but I think disabling from export should not be available in file formats that don't support it

@JannisX11
Copy link
Owner

You have to keep in mind that people can still save project files which include all of this data, including visibility.

@LelouBil
Copy link
Author

Of course, but Blockbench knows the current format of the file so I think a warning is at least needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants