Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain glyphs cut off when they are the right-most symbol being rendered #501

Closed
2 tasks done
stamminator opened this issue Mar 9, 2021 · 10 comments
Closed
2 tasks done

Comments

@stamminator
Copy link

stamminator commented Mar 9, 2021

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

Certain glyphs (for example f7db image) are being cut off if there are no further glyphs to display other than the line terminator. I've confirmed that the issue takes place with both the CaskaydiaCove NF and MesloLGM NF fonts, presumably others as well.

image

Environment

  • Oh my Posh version: 3.106.6
  • Theme: agnoster, agnosterplus, nu4a, slim
  • Operating System: Windows 10 19042.844
  • Shell: PowerShell 7.1.2
  • Terminal: Windows Terminal

Steps to Reproduce

  1. Open the shell at the home directory using one of the above-mentioned themes
  2. Observe that the home icon is cut off
  3. cd one level deeper so that the home icon is no longer the right-most symbol being rendered
  4. Observe that the home icon no longer cuts off

image

@JanDeDobbeleer
Copy link
Owner

@stamminator on first sight this smells like a Windows Terminal issue. I'll try to reproduce this in other terminals too.

@JanDeDobbeleer
Copy link
Owner

Ok, so did some test:

Doesn't happen on iTerm2 (macOS)

image

Doesn't happen on my Windows 10 VM running Terminal Preview:

image

This is definitely related to either the settings on your Windows Terminal or the Windows Terminal itself (I'm on the Preview version).

@tradiff
Copy link
Contributor

tradiff commented Mar 9, 2021

I've seen this happen on lots of icons, and can confirm I see it on the house icon. It's related to the nerdfont you select. And this is on both versions of windows terminal (normal and preview). For example:

"fontFace": "MesloLGM Nerd Font Mono", // small icons but shows the entire icon
"fontFace": "MesloLGM Nerd Font", // large icons but cut off

Sadly, I don't believe OMP can do anything about this.

@JanDeDobbeleer
Copy link
Owner

@travistx @stamminator there was an issue about this in the Windows Terminal backlog but I can't seem to find it anymore (glyph spacing).

@tradiff
Copy link
Contributor

tradiff commented Mar 9, 2021

Yeah I've seen it before. This is probably the one you're thinking of:
microsoft/terminal#5095

@JanDeDobbeleer
Copy link
Owner

@travistx Yes! Thank you!!!

@JanDeDobbeleer
Copy link
Owner

@stamminator until the Terminal team decides to fix this, moving to the mono variant fixes the issue.

@stamminator stamminator changed the title Certain glyphs cut off when they are the left-most symbol being rendered Certain glyphs cut off when they are the right-most symbol being rendered Mar 9, 2021
@stamminator
Copy link
Author

10-4. I tried playing around with inserting special space characters after the icon, like zero-width space ("home_icon": "\uF7DB\u200B"), but no luck. Ultimately, the only options I can see are switching to the mono font or inserting a regular space after the icon as a spacer to make room for the whole icon. Bummer, I like the larger icons.

@JanDeDobbeleer
Copy link
Owner

@stamminator you could always switch to ConEmu or another terminal. Although I admit, Windows Terminal is neat. They'll get there eventually though.

Copy link

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants