You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In particular, warning the user about --seq_len being too small is very important.
I tried to filter that warning with 'once', but:
Python only filters the first occurrence of each exact warning message, even if multiple messages match the same filter's regex.
For some reason, it's not working anyways, probably because the warnings are being printed by the dataloader workers?
These seem to be the only warnings printed during train or test (when everything goes smoothly), so I think notifying the user is important, and removing the full ignore filter will allow through other warnings from actual errors.
The text was updated successfully, but these errors were encountered:
Ultimately I think switching to the package logging is probably a better plan for future. Given that we are not expecting many to use our code directly to create models, is this one case of seq_len important?
I would err on the side of 'warnings all off' unless debug mode is on, just so that logging is at a minimum for the casual user.
I dunno really. If we don't expect users to create models, they won't see the --seq_len warning anyways. That only shows up when training/testing models (and really is important in those cases I'd say, since we're giving them bad data).
Since this is not actually affecting the creation of ACME v1.0, I'm going to kick to the next milestone. We should discuss via skype then, I think it'll be quicker, and record the resolution here.
In particular, warning the user about --seq_len being too small is very important.
I tried to filter that warning with 'once', but:
These seem to be the only warnings printed during train or test (when everything goes smoothly), so I think notifying the user is important, and removing the full ignore filter will allow through other warnings from actual errors.
The text was updated successfully, but these errors were encountered: