Babel vs TSE: TrueKeyword and FalseKeyword

[armano2]

Currently we are parsing TrueKeyword and FalseKeyword as type='Literal' when in type, but babel parses them as BooleanLiteral,

i'm unsure what we should do with this...

[armano2]

Babel expect when used as value:

const test = true;

{
  "type": "Program",
  "sourceType": "script",
  "body": [
    {
      "type": "VariableDeclaration",
      "declarations": [
        {
          "type": "VariableDeclarator",
          "id": {
            "type": "Identifier",
            "name": "test"
          },
          "init": {
            "type": "Literal",
            "value": true,
            "raw": "true"
          }
        }
      ],
      "kind": "const"
    }
  ]
}

when used as type:

type Foo = false

{
  "type": "Program",
  "sourceType": "script",
  "body": [
    {
      "type": "TSTypeAliasDeclaration",
      "id": {
        "type": "Identifier",
        "name": "Foo"
      },
      "typeAnnotation": {
        "type": "TSLiteralType",
        "literal": {
          "type": "BooleanLiteral",
          "value": false
        }
      }
    }
  ]
}

but we are always outputting it as Literal

[JamesHenry]

Hmm yeah, awkward one. IIRC BooleanLiteral is what babel does as standard and then the ESTree plugin converts it to Literal

[armano2]

ok i will investigate that, and most likely report error there

[armano2]

babel/babel#9228

[JamesHenry]

Thanks! I'll leave this issue open for now as a reminder

[JamesHenry]

We're not explicitly tracking any of the other babel issues on this repo so I'm going to close this for consistency with that