Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Inconsistent behavior of "View Source" actions #41

Open
SimonMarquis opened this issue Jan 17, 2018 · 4 comments
Open

Inconsistent behavior of "View Source" actions #41

SimonMarquis opened this issue Jan 17, 2018 · 4 comments

Comments

@SimonMarquis
Copy link

SimonMarquis commented Jan 17, 2018

View source action will lead to 2 different places depending on the button pressed:

  • in the list view (main screen): the View source button of the overflow menu item will open a ChromeCustomTab
  • in the details view (ChromeCustomTab): the View * source button in the ActionBar will open a regular ACTION_VIEW intent, and open whatever browser you have on your device

I'm working on the 2nd View Source action to load the uri into a ChromeCustomTab as well.

@JakeWharton
Copy link
Owner

What's the behavior when you click "View Source" and it launches a custom tab from a custom tab? Does it overlay or does it redirect the current one?

@SimonMarquis
Copy link
Author

It does create another Activity (CustomTab) on top of the current one (back button returns to the initial CustomTab).
Unfortunately, there is no API to redirect the user from within a CustomTab...

@JakeWharton
Copy link
Owner

Yeah I briefly went looking for one before deciding on the ACTION_VIEW intent. I'll try out the overlaying one in your PR and see how it feels.

@SimonMarquis
Copy link
Author

2018-01-17_19-26-03

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants