Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Javadocs show up in omnibar with class name twice, compared to KDocs #183

Open
ChrisCraik opened this issue Mar 4, 2020 · 2 comments
Open

Comments

@ChrisCraik
Copy link

I understand showing both, since they're both on DAC, but the labeling is confusing.

For Debug's javadocs (https://developer.android.com/reference/android/os/Debug)

The name is shown as:
android.os.Debug.Debug

While for the kdocs (https://developer.android.com/reference/kotlin/android/os/Debug)

The name shows in the omnibar as:
android.os.Debug

Consider adding "(kdocs)" or "(javadocs)" to one of them instead to distinguish.

@JakeWharton
Copy link
Owner

Hmm I think this is because I haven't released the extension in a while (thanks kotlin-js) and it still is using old code to sync its database. The new behavior throws all data away and the old behavior incrementally updated things.

The API only returns a single entry for Debug:

$ curl -s https://api.sdksearch.app/list | jq '.[] | select(.className=="Debug")'
{
  "packageName": "android.os",
  "className": "Debug",
  "deprecated": false,
  "link": "https://developer.android.com/reference/kotlin/android/os/Debug",
  "api": 0
}

If you want you can download and try the latest debug build: https://1661-114199331-gh.circle-artifacts.com/0/frontend/chrome-extension/build/distributions/sdk-search-debug.zip (it uses "ad2")

Otherwise I'll try to get a release out today or tomorrow now that I finally was able to migrate to the new JS plugin.

@sudhirkhanger
Copy link

This ad2 build shows only one entry which goes to Kotlin. It is working as expected at least for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants