Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have dynamic check path #15

Closed
jawakarD opened this issue Aug 26, 2021 · 1 comment · Fixed by #16
Closed

Have dynamic check path #15

jawakarD opened this issue Aug 26, 2021 · 1 comment · Fixed by #16

Comments

@jawakarD
Copy link
Contributor

jawakarD commented Aug 26, 2021

As of now, looks like the this action checks for the root path

const url = `https://deploy-preview-${PR_NUMBER}--${siteName}.netlify.app`;
but some sites would not have the root path, but will have other pages. This will throw 404 when the action tries to access the non existing page and won't resolve to 200 at all.

Solution could be to accept a option check_path.

Would like to open a PR if it's fine.

@JakePartusch
Copy link
Owner

@jawakarD, sure go for it! I think that would be a fine enhancement.

Maybe it could be base_path which has a default of /?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants