Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix GitHub Action Run Error #81

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

JackPlowman
Copy link
Owner

@JackPlowman JackPlowman commented Sep 30, 2024

Pull Request

Description

This change optimises the Dockerfile for the analyser project:

  1. Improved the apk add command by moving the --no-cache flag to the beginning, following best practices for Alpine Linux package management.

  2. Replaced the CMD instruction with ENTRYPOINT, ensuring that the analyser module is always executed when the container starts, regardless of any additional command-line arguments passed to docker run.

fixes #82

image

@github-actions github-actions bot added the docker Pull requests that update Docker code label Sep 30, 2024
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on Graphite Graphite

@JackPlowman JackPlowman changed the title Fix Docker Run Error fix: Fix GitHub Action Run Error Sep 30, 2024
@JackPlowman JackPlowman marked this pull request as ready for review September 30, 2024 06:51
Copy link

sonarcloud bot commented Sep 30, 2024

@JackPlowman JackPlowman merged commit 5f09b1e into main Sep 30, 2024
44 of 45 checks passed
Copy link
Owner Author

Merge activity

@JackPlowman JackPlowman deleted the 09-30-fix_docker_run_error branch September 30, 2024 06:54
JackPlowman added a commit that referenced this pull request Oct 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.0.1](v1.0.0...v1.0.1)
(2024-10-01)


### 🐛 Bugfixes

* Fix GitHub Action Run Error
([#81](#81))
([5f09b1e](5f09b1e))


### 🧰 Maintenance

* Add Action Preview workflow
([#85](#85))
([1920a47](1920a47)),
closes
[#86](#86)
* Copy output file to GitHub runner
([#103](#103))
([be39862](be39862)),
closes
[#104](#104)
* Fix analyser directory copy in Dockerfile
([#96](#96))
([291fbec](291fbec)),
closes
[#95](#95)
* Fix script not found
([#91](#91))
([74547b7](74547b7)),
closes
[#92](#92)
* Optimize Dockerfile and update run script
([#99](#99))
([6c0350a](6c0350a)),
closes
[#100](#100)
* Remove debug commands from run script
([#106](#106))
([ef17c68](ef17c68)),
closes
[#105](#105)
* Simplify Dockerfile and update entrypoint
([#88](#88))
([daf607c](daf607c)),
closes
[#87](#87)
* Update Dockerfile and add run script
([#89](#89))
([3a647db](3a647db)),
closes
[#90](#90)
* Update Dockerfile and enhance GitHub Action workflow
([#94](#94))
([68fe555](68fe555)),
closes
[#93](#93)
* Update Dockerfile and enhance run script
([#97](#97))
([0d517ce](0d517ce)),
closes
[#98](#98)
* Update Dockerfile permissions and Python path
([#84](#84))
([7910d75](7910d75)),
closes
[#86](#86)
* Update repository owner environment variable
([#102](#102))
([c9aa465](c9aa465)),
closes
[#101](#101)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix GitHub Actions run error
1 participant