Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplify Dockerfile and update entrypoint #88

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

JackPlowman
Copy link
Owner

@JackPlowman JackPlowman commented Sep 30, 2024

Pull Request

Description

This change simplifies the Dockerfile by removing unnecessary steps and adjusting the entrypoint command. The modifications include:

  • Removed the COPY analyser ./analyser command, as it's no longer needed.
  • Removed the RUN chmod +x analyser command, which is no longer required.
  • Removed the ENV PYTHONPATH=/ environment variable setting.
  • Updated the ENTRYPOINT command to directly run the analyser module using "./analyser" instead of just "analyser".

These changes streamline the Docker build process and reduce the complexity of the Dockerfile while maintaining the functionality of running the analyser module.

fixes #87

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the docker Pull requests that update Docker code label Sep 30, 2024
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Sep 30, 2024
@JackPlowman JackPlowman changed the title Fix docker run ci: Update GitHub Action version and remove PYTHONPATH Sep 30, 2024
@JackPlowman JackPlowman marked this pull request as ready for review September 30, 2024 08:10
@JackPlowman JackPlowman force-pushed the 09-30-fix_docker_run branch 4 times, most recently from 0aa3c8f to e8d75ef Compare September 30, 2024 08:20
@github-actions github-actions bot removed the github_actions Pull requests that update GitHub Actions code label Sep 30, 2024
@JackPlowman JackPlowman changed the title ci: Update GitHub Action version and remove PYTHONPATH chore: Simplify Dockerfile and update entrypoint Sep 30, 2024
@JackPlowman JackPlowman force-pushed the 09-30-fix_docker_run branch 2 times, most recently from 048755d to ab970b1 Compare September 30, 2024 08:24
@github-actions github-actions bot added the just Pull requests that update Just code label Sep 30, 2024
Copy link

sonarcloud bot commented Sep 30, 2024

@JackPlowman JackPlowman merged commit daf607c into main Sep 30, 2024
28 checks passed
Copy link
Owner Author

Merge activity

@JackPlowman JackPlowman deleted the 09-30-fix_docker_run branch September 30, 2024 08:29
JackPlowman added a commit that referenced this pull request Oct 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.0.1](v1.0.0...v1.0.1)
(2024-10-01)


### 🐛 Bugfixes

* Fix GitHub Action Run Error
([#81](#81))
([5f09b1e](5f09b1e))


### 🧰 Maintenance

* Add Action Preview workflow
([#85](#85))
([1920a47](1920a47)),
closes
[#86](#86)
* Copy output file to GitHub runner
([#103](#103))
([be39862](be39862)),
closes
[#104](#104)
* Fix analyser directory copy in Dockerfile
([#96](#96))
([291fbec](291fbec)),
closes
[#95](#95)
* Fix script not found
([#91](#91))
([74547b7](74547b7)),
closes
[#92](#92)
* Optimize Dockerfile and update run script
([#99](#99))
([6c0350a](6c0350a)),
closes
[#100](#100)
* Remove debug commands from run script
([#106](#106))
([ef17c68](ef17c68)),
closes
[#105](#105)
* Simplify Dockerfile and update entrypoint
([#88](#88))
([daf607c](daf607c)),
closes
[#87](#87)
* Update Dockerfile and add run script
([#89](#89))
([3a647db](3a647db)),
closes
[#90](#90)
* Update Dockerfile and enhance GitHub Action workflow
([#94](#94))
([68fe555](68fe555)),
closes
[#93](#93)
* Update Dockerfile and enhance run script
([#97](#97))
([0d517ce](0d517ce)),
closes
[#98](#98)
* Update Dockerfile permissions and Python path
([#84](#84))
([7910d75](7910d75)),
closes
[#86](#86)
* Update repository owner environment variable
([#102](#102))
([c9aa465](c9aa465)),
closes
[#101](#101)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code just Pull requests that update Just code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Analyser github action error
1 participant