-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Simplify Dockerfile and update entrypoint #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JackPlowman and the rest of your teammates on Graphite |
JackPlowman
force-pushed
the
09-30-fix_docker_run
branch
from
September 30, 2024 07:51
a136e7c
to
6002829
Compare
github-actions
bot
added
the
github_actions
Pull requests that update GitHub Actions code
label
Sep 30, 2024
JackPlowman
changed the title
Fix docker run
ci: Update GitHub Action version and remove PYTHONPATH
Sep 30, 2024
JackPlowman
force-pushed
the
09-30-fix_docker_run
branch
4 times, most recently
from
September 30, 2024 08:20
0aa3c8f
to
e8d75ef
Compare
github-actions
bot
removed
the
github_actions
Pull requests that update GitHub Actions code
label
Sep 30, 2024
JackPlowman
changed the title
ci: Update GitHub Action version and remove PYTHONPATH
chore: Simplify Dockerfile and update entrypoint
Sep 30, 2024
JackPlowman
force-pushed
the
09-30-fix_docker_run
branch
2 times, most recently
from
September 30, 2024 08:24
048755d
to
ab970b1
Compare
JackPlowman
force-pushed
the
09-30-fix_docker_run
branch
from
September 30, 2024 08:26
ab970b1
to
e0f5536
Compare
Quality Gate passedIssues Measures |
Merge activity
|
JackPlowman
added a commit
that referenced
this pull request
Oct 1, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2024-10-01) ### 🐛 Bugfixes * Fix GitHub Action Run Error ([#81](#81)) ([5f09b1e](5f09b1e)) ### 🧰 Maintenance * Add Action Preview workflow ([#85](#85)) ([1920a47](1920a47)), closes [#86](#86) * Copy output file to GitHub runner ([#103](#103)) ([be39862](be39862)), closes [#104](#104) * Fix analyser directory copy in Dockerfile ([#96](#96)) ([291fbec](291fbec)), closes [#95](#95) * Fix script not found ([#91](#91)) ([74547b7](74547b7)), closes [#92](#92) * Optimize Dockerfile and update run script ([#99](#99)) ([6c0350a](6c0350a)), closes [#100](#100) * Remove debug commands from run script ([#106](#106)) ([ef17c68](ef17c68)), closes [#105](#105) * Simplify Dockerfile and update entrypoint ([#88](#88)) ([daf607c](daf607c)), closes [#87](#87) * Update Dockerfile and add run script ([#89](#89)) ([3a647db](3a647db)), closes [#90](#90) * Update Dockerfile and enhance GitHub Action workflow ([#94](#94)) ([68fe555](68fe555)), closes [#93](#93) * Update Dockerfile and enhance run script ([#97](#97)) ([0d517ce](0d517ce)), closes [#98](#98) * Update Dockerfile permissions and Python path ([#84](#84)) ([7910d75](7910d75)), closes [#86](#86) * Update repository owner environment variable ([#102](#102)) ([c9aa465](c9aa465)), closes [#101](#101) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This change simplifies the Dockerfile by removing unnecessary steps and adjusting the entrypoint command. The modifications include:
COPY analyser ./analyser
command, as it's no longer needed.RUN chmod +x analyser
command, which is no longer required.ENV PYTHONPATH=/
environment variable setting.ENTRYPOINT
command to directly run the analyser module using"./analyser"
instead of just"analyser"
.These changes streamline the Docker build process and reduce the complexity of the Dockerfile while maintaining the functionality of running the analyser module.
fixes #87