chore: Refactor statistics file handling and improve logging #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JackPlowman and the rest of your teammates on |
JackPlowman
changed the title
JackPlowman
changed the title
JackPlowman
changed the title
|
Merge activity
|
JackPlowman
added a commit
that referenced
this pull request
Oct 6, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](v1.0.1...v1.1.0) (2024-10-06) ### 🚀 Features * Build and Push GitHub Package ([#131](#131)) ([dbbc4df](dbbc4df)), closes [#132](#132) ### 🧰 Maintenance * Add .dockerignore file ([#108](#108)) ([4f96c7d](4f96c7d)), closes [#114](#114) * Add environment variable check script ([#126](#126)) ([2596b6f](2596b6f)), closes [#125](#125) * Create reusable setup-dependencies action ([#123](#123)) ([3ff9743](3ff9743)), closes [#124](#124) * Group GitHub Actions dependencies in Dependabot config ([#112](#112)) ([2cd5914](2cd5914)), closes [#117](#117) * Refactor statistics file handling and improve logging ([#121](#121)) ([c4a3d9e](c4a3d9e)), closes [#122](#122) * Reorganize and expand Justfile commands ([#127](#127)) ([ad0aa60](ad0aa60)), closes [#128](#128) * Standardise environment variable names ([#129](#129)) ([203c593](203c593)), closes [#130](#130) * Update GitHub Actions dependencies ([#113](#113)) ([7a51401](7a51401)), closes [#118](#118) * Update workflows and remove action preview ([#109](#109)) ([db4bf42](db4bf42)), closes [#115](#115) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This change introduces a constant
DEFAULT_FILE_LOCATIONin thestatistics.pyfile to store the path for the repository statistics JSON file. Thecreate_statistics()function now uses this constant when saving the statistics, improving code maintainability.Additionally, a log message has been added to confirm when the statistics file has been saved successfully.
In the
run.shscript, an echo statement has been included to provide feedback when the statistics file is copied to the GitHub workspace directory during CI execution.These modifications enhance code readability, maintainability, and provide better logging for the statistics generation and file handling processes.
fixes #122