-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement an ISBN Fetcher for book-info.com #9145
Comments
Hi @Siedlerchr , |
I'm interested in contributing to this issue, so before I start working it, would you mind sparing your time explaining what the fix will be like. |
General remarks for contribution: Check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Feel free to ask if you have any questions here on GitHub or also at JabRef's Gitter chat. Try to open a (draft) pull request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback. |
@sreenath-tm I have seen you are interested in multiple issues (9031 and 9042). I assume you are a student or a project newcomer and for this reason I would suggest to focus on one of the other issues, since:
|
With regard to the code, Christoph or one of the other maintainers will be able to explain more. I would start with
|
Codewise take a look at the existing ISBN fetchers https://github.com/JabRef/jabref/blob/main/src/main/java/org/jabref/logic/importer/fetcher/IsbnFetcher.java |
@anudeep-bpgc Please do take a look at https://github.com/JabRef/jabref/blob/main/docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace.md to get a headstart. If there is any help needed please feel free to let me know. |
Tomorrow the hacktoberfest starts. I would like to use this task as a project start. Is it ok for you if I take it over? Nothing has happened to the task for 20 days now. |
hi @ezienecker, you may take it. |
I am having trouble adding a new dependency to the project. Unfortunately I don't really understand where the problem is. I added the following dependency ( A normal Gradle build works without problems. I have set up the project as described here https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace. |
@ezienecker why do you want to add a new dependency? You should be able to use jsoup for this. See the implementation of the other fetchers |
The problem with this page is that when you make the call with the appropriate ISBN, you are redirected first (apparently a javascript redirect). The response contains the following in the body tag:
The rest of the body does not provide any useful content. If you now extract this URL and load it in I would alternatively use this site: https://doi-to-bibtex-converter.herokuapp.com/. There you can search for an ISBN and get a JSON back, that looks more usable than this page in my opinion. |
I would like to contribute to this issue and make some improvements. |
@muzhenying, what would these improvements be? I am thankful for your interest, but have you noticed that @ezienecker has already delivered some good work? As you can see there is an open pull-request just waiting to be finalised. Unless you substantially can improve ezeneckers work (I would not know how), I would suggest to look for another issue. If you are pretty new to open source programming, have a look at issues with the tag "good first issues". Good first issues from Koppor also count. If you are a student, the "candidates for university projects" page also offers some issues of varying difficulty and scope and that have been estimated to be compatible with university courses as well and often bring a larger feature to JabRef. |
Thanks, @ThiloteE But actually I had a look at the latest repo and it seems that @ezienecker used a source to implement a new ISBN fetcher so I still want to have a try to see if we can use Book-info as a fallback source. |
…ok-info.com-JabRef#9145 * upstream/main: New Crowdin updates (JabRef#9333) Refresh example styles Squashed 'buildres/csl/csl-styles/' changes from 4eee79a..13fd98e Bump unirest-java from 3.13.11 to 3.13.12 (JabRef#9330) Bump checkstyle from 10.3.4 to 10.4 (JabRef#9331) Bump gittools/actions from 0.9.14 to 0.9.15 (JabRef#9332) Group context menu presents relevant options depending on number of subgroups (JabRef#9286) Removed BibTeX file type and included HTML and Markdown types (JabRef#9318) Fix issue: Auto-linking files with safe character replacements JabRef#9267 (JabRef#9316) Fix for issue 8806: Button highlights doesn't respect rounded corners (JabRef#9320) New Crowdin updates (JabRef#9324) Update CHANGELOG.md Try to relocate listener binding (JabRef#9238) Changed the messages after importing unlinked local files to past passive tense. (JabRef#9308) Changed the color of found text from red to high contrast (JabRef#9315) # Conflicts: # CHANGELOG.md
Is your suggestion for improvement related to a problem? Please describe.
Some ISBNs like 3-85869-197-6 and 3-549-05585-4 cannot be found on OpenLibrary or Ebook.de
Describe the solution you'd like
Add book-info.com as a third fallback source for checking ISBN Data.
Additional context
The HTML needs to be parsed. Seems pretty straightforward to parse the data with jsoup
https://www.book-info.com/isbn/84-08-08890-4.htm
The text was updated successfully, but these errors were encountered: