From 31aa4cfc4441f9fb9c425b6df1f936e77c7e1c59 Mon Sep 17 00:00:00 2001 From: Christina Chen Date: Mon, 16 May 2022 22:24:49 -0700 Subject: [PATCH 1/4] add: add test cases for FileUtil --- .../jabref/logic/util/io/FileUtilTest.java | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/test/java/org/jabref/logic/util/io/FileUtilTest.java b/src/test/java/org/jabref/logic/util/io/FileUtilTest.java index f1b9d1f76d2..e6659fe3609 100644 --- a/src/test/java/org/jabref/logic/util/io/FileUtilTest.java +++ b/src/test/java/org/jabref/logic/util/io/FileUtilTest.java @@ -383,4 +383,23 @@ void testIsNotBibFile() throws IOException { Path bibFile = Files.createFile(rootDir.resolve("test.pdf")); assertFalse(FileUtil.isBibFile(bibFile)); } + + @Test + void testFindinPath() { + Optional resultPath1 = FileUtil.find("existingTestFile.txt", rootDir); + assertEquals(resultPath1.get().toString(), existingTestFile.toString()); + Optional resultPath2 = FileUtil.find("otherExistingTestFile.txt", rootDir); + assertEquals(resultPath2.get().toString(), otherExistingTestFile.toString()); + } + + @Test + void testFindinListofPath() { + Path[] pathArr = {existingTestFile, otherExistingTestFile, rootDir}; + List paths = Arrays.asList(pathArr); + Path[] resultArr = {existingTestFile, existingTestFile}; + List resultPaths = Arrays.asList(resultArr); + List result = FileUtil.find("existingTestFile.txt", paths); + System.out.println(result.toString()); + assertEquals(resultPaths, result); + } } From b39bd6debfadb5e00aa66ae1967775ce61dad1c6 Mon Sep 17 00:00:00 2001 From: Christina Chen Date: Mon, 16 May 2022 22:47:06 -0700 Subject: [PATCH 2/4] del: other --- src/test/java/org/jabref/logic/util/io/FileUtilTest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/test/java/org/jabref/logic/util/io/FileUtilTest.java b/src/test/java/org/jabref/logic/util/io/FileUtilTest.java index e6659fe3609..180fb3559e6 100644 --- a/src/test/java/org/jabref/logic/util/io/FileUtilTest.java +++ b/src/test/java/org/jabref/logic/util/io/FileUtilTest.java @@ -388,8 +388,6 @@ void testIsNotBibFile() throws IOException { void testFindinPath() { Optional resultPath1 = FileUtil.find("existingTestFile.txt", rootDir); assertEquals(resultPath1.get().toString(), existingTestFile.toString()); - Optional resultPath2 = FileUtil.find("otherExistingTestFile.txt", rootDir); - assertEquals(resultPath2.get().toString(), otherExistingTestFile.toString()); } @Test From 8bfbcf07f464b540719b458d66dd990a9db16091 Mon Sep 17 00:00:00 2001 From: Christina Chen Date: Mon, 16 May 2022 23:03:27 -0700 Subject: [PATCH 3/4] fix: list of --- src/test/java/org/jabref/logic/util/io/FileUtilTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/java/org/jabref/logic/util/io/FileUtilTest.java b/src/test/java/org/jabref/logic/util/io/FileUtilTest.java index 180fb3559e6..37c2fadb777 100644 --- a/src/test/java/org/jabref/logic/util/io/FileUtilTest.java +++ b/src/test/java/org/jabref/logic/util/io/FileUtilTest.java @@ -393,11 +393,10 @@ void testFindinPath() { @Test void testFindinListofPath() { Path[] pathArr = {existingTestFile, otherExistingTestFile, rootDir}; - List paths = Arrays.asList(pathArr); + List paths = List.of(pathArr); Path[] resultArr = {existingTestFile, existingTestFile}; - List resultPaths = Arrays.asList(resultArr); + List resultPaths = List.of(resultArr); List result = FileUtil.find("existingTestFile.txt", paths); - System.out.println(result.toString()); assertEquals(resultPaths, result); } } From cc915da2099ef32d03422f902cb8942aeeb99857 Mon Sep 17 00:00:00 2001 From: Christina Chen Date: Tue, 17 May 2022 09:59:15 -0700 Subject: [PATCH 4/4] fix: list of --- src/test/java/org/jabref/logic/util/io/FileUtilTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/jabref/logic/util/io/FileUtilTest.java b/src/test/java/org/jabref/logic/util/io/FileUtilTest.java index 37c2fadb777..3392003f3a2 100644 --- a/src/test/java/org/jabref/logic/util/io/FileUtilTest.java +++ b/src/test/java/org/jabref/logic/util/io/FileUtilTest.java @@ -392,10 +392,8 @@ void testFindinPath() { @Test void testFindinListofPath() { - Path[] pathArr = {existingTestFile, otherExistingTestFile, rootDir}; - List paths = List.of(pathArr); - Path[] resultArr = {existingTestFile, existingTestFile}; - List resultPaths = List.of(resultArr); + List paths = List.of(existingTestFile, otherExistingTestFile, rootDir); + List resultPaths = List.of(existingTestFile, existingTestFile); List result = FileUtil.find("existingTestFile.txt", paths); assertEquals(resultPaths, result); }