Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: no visual clue about selected options #8014

Closed
2 tasks done
mlep opened this issue Aug 23, 2021 · 1 comment · Fixed by #8023
Closed
2 tasks done

Search: no visual clue about selected options #8014

mlep opened this issue Aug 23, 2021 · 1 comment · Fixed by #8023

Comments

@mlep
Copy link
Contributor

mlep commented Aug 23, 2021

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.4--2021-08-23--29d0c80 Linux 4.19.0-17-amd64 amd64 Java 16.0.2 JavaFX 16+8

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

When searching inside a bib file, there is no visual clue if "regular expression", "case sensitive" and "fulltext search" are active or not: the icons remain the same.

  1. Open a bib file (such as https://github.com/JabRef/jabref/blob/main/src/test/resources/testbib/jabref-authors.bib)
  2. Type a string in the search bar
  3. click/unclick on the "regular expression", "case sensitive" and "fulltext search" icons.
    ==> The list of displayed entries (and the message "Found XY results") changes (so the functions behind the icons work), but the icon appearance remains the same.

Remarks:

  • valid for both light and dark themes.
  • bug was introduced between JabRef 5.4--2021-08-15--96061b7 and JabRef 5.4--2021-08-16--2f36a33 (maybe related to PR Fix icon color #7994 ?)

Appendix

...

Log File ``` Paste an excerpt of your log file here ```
@mlep
Copy link
Contributor Author

mlep commented Aug 24, 2021

@calixtus: Thank you for solving this issue. It works well now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant