diff --git a/src/main/java/org/jabref/gui/externalfiletype/CustomizeExternalFileTypesViewModel.java b/src/main/java/org/jabref/gui/externalfiletype/CustomizeExternalFileTypesViewModel.java index 5d8c68e9fa4..4a250f6f549 100644 --- a/src/main/java/org/jabref/gui/externalfiletype/CustomizeExternalFileTypesViewModel.java +++ b/src/main/java/org/jabref/gui/externalfiletype/CustomizeExternalFileTypesViewModel.java @@ -8,9 +8,11 @@ import javafx.collections.ObservableList; import org.jabref.gui.icon.IconTheme; +import org.jabref.logic.l10n.Localization; public class CustomizeExternalFileTypesViewModel { - private ObservableList fileTypes; + + private final ObservableList fileTypes; public CustomizeExternalFileTypesViewModel() { Set types = ExternalFileTypes.getInstance().getExternalFileTypeSelection(); @@ -34,14 +36,14 @@ public void resetToDefaults() { public void addNewType() { CustomExternalFileType type = new CustomExternalFileType("", "", "", "", "new", IconTheme.JabRefIcons.FILE); fileTypes.add(type); - edit(type); + showEditDialog(type, Localization.lang("Add new file type")); } public ObservableList getFileTypes() { return fileTypes; } - public void edit(ExternalFileType type) { + private void showEditDialog(ExternalFileType type, String dialogTitle) { CustomExternalFileType typeForEdit; if (type instanceof CustomExternalFileType) { typeForEdit = (CustomExternalFileType) type; @@ -49,8 +51,12 @@ public void edit(ExternalFileType type) { typeForEdit = new CustomExternalFileType(type); } - ExternalFileTypeEntryEditor entryEditor = new ExternalFileTypeEntryEditor(typeForEdit); - entryEditor.setVisible(true); + EditExternalFileTypeEntryDialog dlg = new EditExternalFileTypeEntryDialog(typeForEdit, dialogTitle); + dlg.showAndWait(); + } + + public void edit(ExternalFileType type) { + showEditDialog(type, Localization.lang("Edit file type")); } public void remove(ExternalFileType type) { diff --git a/src/main/java/org/jabref/gui/externalfiletype/EditExternalFileTypeDialog.fxml b/src/main/java/org/jabref/gui/externalfiletype/EditExternalFileTypeDialog.fxml new file mode 100644 index 00000000000..11da6fc3712 --- /dev/null +++ b/src/main/java/org/jabref/gui/externalfiletype/EditExternalFileTypeDialog.fxml @@ -0,0 +1,54 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +