From 8aeace21edb4a41da44dd5ca6cf60ef693fbadec Mon Sep 17 00:00:00 2001 From: "Harshit.Gupta7" Date: Tue, 23 Jan 2024 11:35:48 +0530 Subject: [PATCH 01/10] #10506 Added new integrity and clean up for non NFC --- CHANGELOG.md | 9 ++++ .../jabref/logic/formatter/Formatters.java | 2 + .../NormalizeUnicodeFormatter.java | 41 +++++++++++++++++++ .../jabref/logic/integrity/FieldCheckers.java | 2 + .../logic/integrity/IntegrityCheck.java | 1 + .../logic/integrity/PersonNamesChecker.java | 3 +- .../integrity/UnicodeNormalFormCCheck.java | 29 +++++++++++++ .../strings/HTMLUnicodeConversionMaps.java | 4 +- .../UnicodeNormalFormCCheckTest.java | 30 ++++++++++++++ 9 files changed, 119 insertions(+), 2 deletions(-) create mode 100644 src/main/java/org/jabref/logic/formatter/bibtexfields/NormalizeUnicodeFormatter.java create mode 100644 src/main/java/org/jabref/logic/integrity/UnicodeNormalFormCCheck.java create mode 100644 src/test/java/org/jabref/logic/integrity/UnicodeNormalFormCCheckTest.java diff --git a/CHANGELOG.md b/CHANGELOG.md index f3759e8323a..8f0e5629548 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,15 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed the colors of the icon on hover for unset special fields. [#10431](https://github.com/JabRef/jabref/issues/10431) ### Removed +## [5.13] – 2024-01-23 +### Fixed +- Fixed an open issue Add quality check and cleanup for problematic unicode characters.[#10506] + +### Added + +- Added new Integrity check option for Non NFC format values.[#10506] +- Added new Clean up option to formate the Non NFC values.[#10506] + ## [5.12] – 2023-12-24 diff --git a/src/main/java/org/jabref/logic/formatter/Formatters.java b/src/main/java/org/jabref/logic/formatter/Formatters.java index 82fb14932e8..bcc7c202295 100644 --- a/src/main/java/org/jabref/logic/formatter/Formatters.java +++ b/src/main/java/org/jabref/logic/formatter/Formatters.java @@ -22,6 +22,7 @@ import org.jabref.logic.formatter.bibtexfields.NormalizeMonthFormatter; import org.jabref.logic.formatter.bibtexfields.NormalizeNamesFormatter; import org.jabref.logic.formatter.bibtexfields.NormalizePagesFormatter; +import org.jabref.logic.formatter.bibtexfields.NormalizeUnicodeFormatter; import org.jabref.logic.formatter.bibtexfields.OrdinalsToSuperscriptFormatter; import org.jabref.logic.formatter.bibtexfields.RegexFormatter; import org.jabref.logic.formatter.bibtexfields.RemoveBracesFormatter; @@ -87,6 +88,7 @@ public static List getOthers() { new EscapeAmpersandsFormatter(), new EscapeDollarSignFormatter(), new ShortenDOIFormatter(), + new NormalizeUnicodeFormatter(), new ReplaceUnicodeLigaturesFormatter(), new UnprotectTermsFormatter() ); diff --git a/src/main/java/org/jabref/logic/formatter/bibtexfields/NormalizeUnicodeFormatter.java b/src/main/java/org/jabref/logic/formatter/bibtexfields/NormalizeUnicodeFormatter.java new file mode 100644 index 00000000000..1bf00558ed6 --- /dev/null +++ b/src/main/java/org/jabref/logic/formatter/bibtexfields/NormalizeUnicodeFormatter.java @@ -0,0 +1,41 @@ +package org.jabref.logic.formatter.bibtexfields; + +import java.text.Normalizer; +import java.util.Objects; + +import org.jabref.logic.cleanup.Formatter; + +/** + * Clean up field values by formatting Unicode values with Normalize Unicode + */ +public class NormalizeUnicodeFormatter extends Formatter { + + @Override + public String getName() { + return "Normalize Unicode"; + } + + @Override + public String getKey() { + return "NORMALIZE_UNICODE"; + } + + @Override + public String getDescription() { + return "Normalize Unicode characters in BibTeX fields."; + } + + @Override + public String getExampleInput() { + return "H\u00E9ll\u00F4 W\u00F6rld"; + } + + @Override + public String format(String value) { + Objects.requireNonNull(value); + + String normalizedValue = Normalizer.normalize(value, Normalizer.Form.NFC); + + return normalizedValue; + } +} diff --git a/src/main/java/org/jabref/logic/integrity/FieldCheckers.java b/src/main/java/org/jabref/logic/integrity/FieldCheckers.java index 0ed0bb82d10..f14dac3380b 100644 --- a/src/main/java/org/jabref/logic/integrity/FieldCheckers.java +++ b/src/main/java/org/jabref/logic/integrity/FieldCheckers.java @@ -53,6 +53,8 @@ private static Multimap getAllMap(BibDatabaseContext databa fieldCheckers.put(StandardField.URLDATE, new DateChecker()); fieldCheckers.put(StandardField.EVENTDATE, new DateChecker()); fieldCheckers.put(StandardField.ORIGDATE, new DateChecker()); +// fieldCheckers.put(StandardField.TITLE, new UnicodeNormalFormCCheck(databaseContext)); +// fieldCheckers.put(StandardField.AUTHOR, new UnicodeNormalFormCCheck(databaseContext)); } return fieldCheckers; diff --git a/src/main/java/org/jabref/logic/integrity/IntegrityCheck.java b/src/main/java/org/jabref/logic/integrity/IntegrityCheck.java index bcf87382a55..bd8659f3e50 100644 --- a/src/main/java/org/jabref/logic/integrity/IntegrityCheck.java +++ b/src/main/java/org/jabref/logic/integrity/IntegrityCheck.java @@ -52,6 +52,7 @@ public IntegrityCheck(BibDatabaseContext bibDatabaseContext, entryCheckers.addAll(List.of( new ASCIICharacterChecker(), new NoBibtexFieldChecker(), + new UnicodeNormalFormCCheck(), new BibTeXEntryTypeChecker()) ); } diff --git a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java index 59c39fea13e..ebfdc462862 100644 --- a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java +++ b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java @@ -40,8 +40,9 @@ public Optional checkValue(String value) { if (!authorList.getAsLastFirstNamesWithAnd(false).equals(value) && !authorList.getAsFirstLastNamesWithAnd().equals(value)) { return Optional.of(Localization.lang("Names are not in the standard %0 format.", bibMode.getFormattedName())); - } + } +// boolean asciiOnly = CharMatcher.ascii().matchesAllOf(authorList.); return Optional.empty(); } } diff --git a/src/main/java/org/jabref/logic/integrity/UnicodeNormalFormCCheck.java b/src/main/java/org/jabref/logic/integrity/UnicodeNormalFormCCheck.java new file mode 100644 index 00000000000..31a4e74bc8f --- /dev/null +++ b/src/main/java/org/jabref/logic/integrity/UnicodeNormalFormCCheck.java @@ -0,0 +1,29 @@ +package org.jabref.logic.integrity; + +import java.text.Normalizer; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; + +import org.jabref.logic.l10n.Localization; +import org.jabref.model.entry.BibEntry; +import org.jabref.model.entry.field.Field; + +/** + * Detect any Unicode characters that is not in NFC format + */ +public class UnicodeNormalFormCCheck implements EntryChecker { + + @Override + public List check(BibEntry entry) { + List results = new ArrayList<>(); + for (Map.Entry field : entry.getFieldMap().entrySet()) { + String normalizedString = Normalizer.normalize(field.getValue(), Normalizer.Form.NFC); + if (!(field.getValue().equals(normalizedString))) { + results.add(new IntegrityMessage(Localization.lang("Value is not in Normal Form C (NFC) format"), entry, + field.getKey())); + } + } + return results; + } +} diff --git a/src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java b/src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java index 86973053a09..5721b88be7e 100644 --- a/src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java +++ b/src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java @@ -40,7 +40,7 @@ public class HTMLUnicodeConversionMaps { {"168", "uml", "{\\\"{}}"}, // diaeresis = spacing diaeresis, // U+00A8 ISOdia {"169", "copy", "{\\copyright}"}, // copyright sign, U+00A9 ISOnum - {"170", "ordf", "{\\textordfeminine}"}, // feminine ordinal indicator, U+00AA ISOnum + {"170", "ordf", "{\\textordfeminine}"}, // feminine ordinal indicator, U+00A A ISOnum {"171", "laquo", "{\\guillemotleft}"}, // left-pointing double angle quotation mark // = left pointing guillemet, U+00AB ISOnum {"172", "not", "$\\neg$"}, // not sign, U+00AC ISOnum @@ -134,6 +134,8 @@ public class HTMLUnicodeConversionMaps { // U+00D8 ISOlat1 {"217", "Ugrave", "{{\\`{U}}}"}, // latin capital letter U with grave, // U+00D9 ISOlat1 + + {"218", "Uacute", "{{\\'{U}}}"}, // latin capital letter U with acute, // U+00DA ISOlat1 {"219", "Ucirc", "{{\\^{U}}}"}, // latin capital letter U with circumflex, diff --git a/src/test/java/org/jabref/logic/integrity/UnicodeNormalFormCCheckTest.java b/src/test/java/org/jabref/logic/integrity/UnicodeNormalFormCCheckTest.java new file mode 100644 index 00000000000..b9354c1a716 --- /dev/null +++ b/src/test/java/org/jabref/logic/integrity/UnicodeNormalFormCCheckTest.java @@ -0,0 +1,30 @@ +package org.jabref.logic.integrity; + +import org.jabref.model.entry.BibEntry; +import org.jabref.model.entry.field.StandardField; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class UnicodeNormalFormCCheckTest { + UnicodeNormalFormCCheck checker = new UnicodeNormalFormCCheck(); + BibEntry entry = new BibEntry(); + + @Test + void checkWithNormalizedStringShouldReturnEmptyList() { + entry.setField(StandardField.TITLE, "Some Title"); + entry.setField(StandardField.AUTHOR, "John Doe"); + + assertTrue(checker.check(entry).isEmpty()); + } + + @Test + void checkWithNonNormalizedStringShouldReturnIntegrityMessage() { + entry.setField(StandardField.TITLE, "Café"); + entry.setField(StandardField.AUTHOR, "John Doe"); + + assertFalse(checker.check(entry).isEmpty()); + } +} From 01496e2c22dfc74a718eea64ebbf410b38fd16e6 Mon Sep 17 00:00:00 2001 From: "Harshit.Gupta7" Date: Tue, 23 Jan 2024 16:22:42 +0530 Subject: [PATCH 02/10] #10506 Add key in JabRef_en.properties --- .../org/jabref/logic/integrity/PersonNamesChecker.java | 1 - src/main/resources/l10n/JabRef_en.properties | 4 +++- .../logic/integrity/UnicodeNormalFormCCheckTest.java | 8 ++++++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java index ebfdc462862..bdfb1261eb7 100644 --- a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java +++ b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java @@ -42,7 +42,6 @@ public Optional checkValue(String value) { return Optional.of(Localization.lang("Names are not in the standard %0 format.", bibMode.getFormattedName())); } -// boolean asciiOnly = CharMatcher.ascii().matchesAllOf(authorList.); return Optional.empty(); } } diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties index 8f76f56d288..fddcc25a802 100644 --- a/src/main/resources/l10n/JabRef_en.properties +++ b/src/main/resources/l10n/JabRef_en.properties @@ -2633,4 +2633,6 @@ Show\ user\ comments\ field=Show user comments field More\ options...=More options... Treat\ all\ duplicates\ entries\ the\ same\ way=Treat all duplicates entries the same way -Ask\ every\ time=Ask every time \ No newline at end of file +Ask\ every\ time=Ask every time + +Value\ is\ not\ in\ Normal\ Form\ C\ (NFC)\ format=Value is not in Normal Form C (NFC) format diff --git a/src/test/java/org/jabref/logic/integrity/UnicodeNormalFormCCheckTest.java b/src/test/java/org/jabref/logic/integrity/UnicodeNormalFormCCheckTest.java index b9354c1a716..24c8cde1004 100644 --- a/src/test/java/org/jabref/logic/integrity/UnicodeNormalFormCCheckTest.java +++ b/src/test/java/org/jabref/logic/integrity/UnicodeNormalFormCCheckTest.java @@ -1,12 +1,15 @@ package org.jabref.logic.integrity; +import java.util.Collections; +import java.util.List; + import org.jabref.model.entry.BibEntry; import org.jabref.model.entry.field.StandardField; import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; -import static org.junit.jupiter.api.Assertions.assertTrue; public class UnicodeNormalFormCCheckTest { UnicodeNormalFormCCheck checker = new UnicodeNormalFormCCheck(); @@ -17,7 +20,7 @@ void checkWithNormalizedStringShouldReturnEmptyList() { entry.setField(StandardField.TITLE, "Some Title"); entry.setField(StandardField.AUTHOR, "John Doe"); - assertTrue(checker.check(entry).isEmpty()); + assertEquals(Collections.emptyList(), checker.check(entry)); } @Test @@ -26,5 +29,6 @@ void checkWithNonNormalizedStringShouldReturnIntegrityMessage() { entry.setField(StandardField.AUTHOR, "John Doe"); assertFalse(checker.check(entry).isEmpty()); + assertEquals(List.of(new IntegrityMessage("Value is not in Normal Form C (NFC) format", entry, StandardField.TITLE)), checker.check(entry)); } } From 5a90ec879d1582769859ed938d25567212abe7e7 Mon Sep 17 00:00:00 2001 From: "Harshit.Gupta7" Date: Tue, 23 Jan 2024 19:09:21 +0530 Subject: [PATCH 03/10] #10506 Fixed checkstyle and markedown error --- CHANGELOG.md | 9 ++++++--- .../org/jabref/logic/integrity/PersonNamesChecker.java | 1 - 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8f0e5629548..8e0dbd114fe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,14 +32,17 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We fixed the colors of the icon on hover for unset special fields. [#10431](https://github.com/JabRef/jabref/issues/10431) ### Removed + ## [5.13] – 2024-01-23 + ### Fixed -- Fixed an open issue Add quality check and cleanup for problematic unicode characters.[#10506] + +- Fixed an open issue Add quality check and cleanup for problematic unicode characters.[#10506](https://github.com/JabRef/jabref/issues/10506) ### Added -- Added new Integrity check option for Non NFC format values.[#10506] -- Added new Clean up option to formate the Non NFC values.[#10506] +- Added new Integrity check option for Non NFC format values.[#10506](https://github.com/JabRef/jabref/issues/10506) +- Added new Clean up option to formate the Non NFC values.[#10506](https://github.com/JabRef/jabref/issues/10506) ## [5.12] – 2023-12-24 diff --git a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java index bdfb1261eb7..7c20e9d3209 100644 --- a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java +++ b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java @@ -40,7 +40,6 @@ public Optional checkValue(String value) { if (!authorList.getAsLastFirstNamesWithAnd(false).equals(value) && !authorList.getAsFirstLastNamesWithAnd().equals(value)) { return Optional.of(Localization.lang("Names are not in the standard %0 format.", bibMode.getFormattedName())); - } return Optional.empty(); } From 0c5acfdb67bc0a762cacec5f73f90a03a0ab29e8 Mon Sep 17 00:00:00 2001 From: "Harshit.Gupta7" Date: Tue, 23 Jan 2024 19:28:18 +0530 Subject: [PATCH 04/10] #10506 fixed CHANGELOG.md error --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e0dbd114fe..6613ea82cb9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,7 +33,6 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv ### Removed -## [5.13] – 2024-01-23 ### Fixed From 52ef5dc079d72863dc0a6ae2874b00cdb4ab07ec Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Tue, 23 Jan 2024 17:49:06 +0100 Subject: [PATCH 05/10] Update CHANGELOG.md --- CHANGELOG.md | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6613ea82cb9..ed76f8956c6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - We added a fetcher for [ISIDORE](https://isidore.science/), simply paste in the link into the text field or the last 6 digits in the link that identify that paper. [#10423](https://github.com/JabRef/jabref/issues/10423) - When importing entries form the "Citation relations" tab, the field [cites](https://docs.jabref.org/advanced/entryeditor/entrylinks) is now filled according to the relationship between the entries. [#10572](https://github.com/JabRef/jabref/pull/10752) +- We added a new integrity check and clean up option for non NFC format values. [#10506](https://github.com/JabRef/jabref/issues/10506) ### Changed @@ -33,17 +34,6 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv ### Removed - -### Fixed - -- Fixed an open issue Add quality check and cleanup for problematic unicode characters.[#10506](https://github.com/JabRef/jabref/issues/10506) - -### Added - -- Added new Integrity check option for Non NFC format values.[#10506](https://github.com/JabRef/jabref/issues/10506) -- Added new Clean up option to formate the Non NFC values.[#10506](https://github.com/JabRef/jabref/issues/10506) - - ## [5.12] – 2023-12-24 ### Added From 0c893adbc7f0d35e18d5fae5d6a20bdbb6239624 Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Tue, 23 Jan 2024 17:54:57 +0100 Subject: [PATCH 06/10] Removed whitespaces unnecessary whitespace changes --- .../jabref/logic/util/strings/HTMLUnicodeConversionMaps.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java b/src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java index 5721b88be7e..86973053a09 100644 --- a/src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java +++ b/src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java @@ -40,7 +40,7 @@ public class HTMLUnicodeConversionMaps { {"168", "uml", "{\\\"{}}"}, // diaeresis = spacing diaeresis, // U+00A8 ISOdia {"169", "copy", "{\\copyright}"}, // copyright sign, U+00A9 ISOnum - {"170", "ordf", "{\\textordfeminine}"}, // feminine ordinal indicator, U+00A A ISOnum + {"170", "ordf", "{\\textordfeminine}"}, // feminine ordinal indicator, U+00AA ISOnum {"171", "laquo", "{\\guillemotleft}"}, // left-pointing double angle quotation mark // = left pointing guillemet, U+00AB ISOnum {"172", "not", "$\\neg$"}, // not sign, U+00AC ISOnum @@ -134,8 +134,6 @@ public class HTMLUnicodeConversionMaps { // U+00D8 ISOlat1 {"217", "Ugrave", "{{\\`{U}}}"}, // latin capital letter U with grave, // U+00D9 ISOlat1 - - {"218", "Uacute", "{{\\'{U}}}"}, // latin capital letter U with acute, // U+00DA ISOlat1 {"219", "Ucirc", "{{\\^{U}}}"}, // latin capital letter U with circumflex, From 87b391ce454ec50658f6604d9508ec2dde86d953 Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Tue, 23 Jan 2024 17:55:48 +0100 Subject: [PATCH 07/10] Removed unnecessary whitespace change --- src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java index 7c20e9d3209..a9a9edae0b2 100644 --- a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java +++ b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java @@ -42,5 +42,6 @@ public Optional checkValue(String value) { return Optional.of(Localization.lang("Names are not in the standard %0 format.", bibMode.getFormattedName())); } return Optional.empty(); + } } From 9465fe42f25d8fb40b1ad19060f694761f6ccab2 Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Tue, 23 Jan 2024 17:56:15 +0100 Subject: [PATCH 08/10] Update PersonNamesChecker.java --- .../java/org/jabref/logic/integrity/PersonNamesChecker.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java index a9a9edae0b2..ebc274eba8c 100644 --- a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java +++ b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java @@ -41,7 +41,7 @@ public Optional checkValue(String value) { && !authorList.getAsFirstLastNamesWithAnd().equals(value)) { return Optional.of(Localization.lang("Names are not in the standard %0 format.", bibMode.getFormattedName())); } + return Optional.empty(); - } } From 3cb04bc37002fd4f7a03fe1181a16e3741189c9c Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Tue, 23 Jan 2024 17:56:35 +0100 Subject: [PATCH 09/10] Update PersonNamesChecker.java --- .../java/org/jabref/logic/integrity/PersonNamesChecker.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java index ebc274eba8c..59c39fea13e 100644 --- a/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java +++ b/src/main/java/org/jabref/logic/integrity/PersonNamesChecker.java @@ -41,7 +41,7 @@ public Optional checkValue(String value) { && !authorList.getAsFirstLastNamesWithAnd().equals(value)) { return Optional.of(Localization.lang("Names are not in the standard %0 format.", bibMode.getFormattedName())); } - + return Optional.empty(); } } From ab88b5510197a2b3a7a443b728b7f100ea744a9f Mon Sep 17 00:00:00 2001 From: "Harshit.Gupta7" Date: Wed, 24 Jan 2024 15:42:42 +0530 Subject: [PATCH 10/10] #10506 Remove unnecessary comment line in FieldCheckers --- src/main/java/org/jabref/logic/integrity/FieldCheckers.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/main/java/org/jabref/logic/integrity/FieldCheckers.java b/src/main/java/org/jabref/logic/integrity/FieldCheckers.java index f14dac3380b..0ed0bb82d10 100644 --- a/src/main/java/org/jabref/logic/integrity/FieldCheckers.java +++ b/src/main/java/org/jabref/logic/integrity/FieldCheckers.java @@ -53,8 +53,6 @@ private static Multimap getAllMap(BibDatabaseContext databa fieldCheckers.put(StandardField.URLDATE, new DateChecker()); fieldCheckers.put(StandardField.EVENTDATE, new DateChecker()); fieldCheckers.put(StandardField.ORIGDATE, new DateChecker()); -// fieldCheckers.put(StandardField.TITLE, new UnicodeNormalFormCCheck(databaseContext)); -// fieldCheckers.put(StandardField.AUTHOR, new UnicodeNormalFormCCheck(databaseContext)); } return fieldCheckers;