From 0594cb236f6998a60fa1f6f85fb24967fb4e4eaa Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Tue, 10 Oct 2023 23:15:59 +0200 Subject: [PATCH 1/4] Use .COMMENT instead of outdated .REVIEW --- CHANGELOG.md | 1 + .../java/org/jabref/logic/importer/fileformat/IsiImporter.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b4e10494f9..f2deb3880c9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - The ampersand checker now skips verbatim fields (`file`, `url`, ...). [#10419](https://github.com/JabRef/jabref/pull/10419) - If no existing document is selected for exporting "XMP annotated pdf" JabRef will now create a new PDF file with a sample text and the metadata. [#10102](https://github.com/JabRef/jabref/issues/10102) - We modified the DOI cleanup to infer the DOI from an ArXiV ID if it's present. [10426](https://github.com/JabRef/jabref/issues/10426) +- The Medline importer uses the field `comment` for notes (instead of `review). ### Fixed diff --git a/src/main/java/org/jabref/logic/importer/fileformat/IsiImporter.java b/src/main/java/org/jabref/logic/importer/fileformat/IsiImporter.java index 6b5a4cead56..56b6b4052ae 100644 --- a/src/main/java/org/jabref/logic/importer/fileformat/IsiImporter.java +++ b/src/main/java/org/jabref/logic/importer/fileformat/IsiImporter.java @@ -97,7 +97,7 @@ public boolean isRecognizedFormat(BufferedReader reader) throws IOException { } public static void processSubSup(Map map) { - Field[] subsup = {StandardField.TITLE, StandardField.ABSTRACT, StandardField.REVIEW, new UnknownField("notes")}; + Field[] subsup = {StandardField.TITLE, StandardField.ABSTRACT, StandardField.COMMENT, new UnknownField("notes")}; for (Field aSubsup : subsup) { if (map.containsKey(aSubsup)) { From 26d0026b166a03bbe7b4af819e97149fc259e840 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Tue, 10 Oct 2023 23:20:18 +0200 Subject: [PATCH 2/4] Adapt tests of IsiImporter --- .../jabref/logic/importer/fileformat/IsiImporterTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/jabref/logic/importer/fileformat/IsiImporterTest.java b/src/test/java/org/jabref/logic/importer/fileformat/IsiImporterTest.java index b77c78660d2..1739ac4ee28 100644 --- a/src/test/java/org/jabref/logic/importer/fileformat/IsiImporterTest.java +++ b/src/test/java/org/jabref/logic/importer/fileformat/IsiImporterTest.java @@ -98,9 +98,9 @@ public void testProcessSubSup() { IsiImporter.processSubSup(subs); assertEquals("$_3$", subs.get(StandardField.ABSTRACT)); - subs.put(StandardField.REVIEW, "/sub 31/"); + subs.put(StandardField.COMMENT, "/sub 31/"); IsiImporter.processSubSup(subs); - assertEquals("$_{31}$", subs.get(StandardField.REVIEW)); + assertEquals("$_{31}$", subs.get(StandardField.COMMENT)); subs.put(StandardField.TITLE, "/sup 3/"); IsiImporter.processSubSup(subs); @@ -114,9 +114,9 @@ public void testProcessSubSup() { IsiImporter.processSubSup(subs); assertEquals("$^3$", subs.get(StandardField.ABSTRACT)); - subs.put(StandardField.REVIEW, "/sup 31/"); + subs.put(StandardField.COMMENT, "/sup 31/"); IsiImporter.processSubSup(subs); - assertEquals("$^{31}$", subs.get(StandardField.REVIEW)); + assertEquals("$^{31}$", subs.get(StandardField.COMMENT)); subs.put(StandardField.TITLE, "/sub $Hello/"); IsiImporter.processSubSup(subs); From 9f1f394f5eecd661c2f29726a2f33cf6987fe75f Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Tue, 10 Oct 2023 23:28:14 +0200 Subject: [PATCH 3/4] Update CHANGELOG.md Co-authored-by: Christoph --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f2deb3880c9..57f8cf01bfc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,7 +28,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - The ampersand checker now skips verbatim fields (`file`, `url`, ...). [#10419](https://github.com/JabRef/jabref/pull/10419) - If no existing document is selected for exporting "XMP annotated pdf" JabRef will now create a new PDF file with a sample text and the metadata. [#10102](https://github.com/JabRef/jabref/issues/10102) - We modified the DOI cleanup to infer the DOI from an ArXiV ID if it's present. [10426](https://github.com/JabRef/jabref/issues/10426) -- The Medline importer uses the field `comment` for notes (instead of `review). +- The ISI importer uses the field `comment` for notes (instead of `review). ### Fixed From 7ec949fcb878a0b69747a65e94f4fd1fa25ac4dc Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Wed, 11 Oct 2023 12:00:37 +0200 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 57f8cf01bfc..66bdbee9257 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,8 +27,8 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv - When searching for an identifier in the "Web search", the title of the search window is now "Identifier-based Web Search". [#10391](https://github.com/JabRef/jabref/pull/10391) - The ampersand checker now skips verbatim fields (`file`, `url`, ...). [#10419](https://github.com/JabRef/jabref/pull/10419) - If no existing document is selected for exporting "XMP annotated pdf" JabRef will now create a new PDF file with a sample text and the metadata. [#10102](https://github.com/JabRef/jabref/issues/10102) -- We modified the DOI cleanup to infer the DOI from an ArXiV ID if it's present. [10426](https://github.com/JabRef/jabref/issues/10426) -- The ISI importer uses the field `comment` for notes (instead of `review). +- We modified the DOI cleanup to infer the DOI from an ArXiV ID if it's present. [#10426](https://github.com/JabRef/jabref/issues/10426) +- The ISI importer uses the field `comment` for notes (instead of `review). [#10478](https://github.com/JabRef/jabref/pull/10478) ### Fixed