From d2b056da851a4c661d842e615503d67af1676f1e Mon Sep 17 00:00:00 2001 From: DohaRamadan <77820526+DohaRamadan@users.noreply.github.com> Date: Thu, 31 Aug 2023 11:42:18 +0300 Subject: [PATCH 1/3] Fixed saving radio button choice under specified keywords --- src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java b/src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java index 04b5e39c278..12c6300980b 100644 --- a/src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java +++ b/src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java @@ -334,6 +334,7 @@ public AbstractGroup resultConverter(ButtonType button) { // Set default value for delimiters: ',' for base and '>' for hierarchical char delimiter = ','; char hierarDelimiter = Keyword.DEFAULT_HIERARCHICAL_DELIMITER; + autoGroupKeywordsOptionProperty.setValue(Boolean.TRUE); // Modify values for delimiters if user provided customized values if (!autoGroupKeywordsDelimiterProperty.getValue().isEmpty()) { delimiter = autoGroupKeywordsDelimiterProperty.getValue().charAt(0); @@ -423,11 +424,13 @@ public void setValues() { if (editedGroup.getClass() == AutomaticKeywordGroup.class) { AutomaticKeywordGroup group = (AutomaticKeywordGroup) editedGroup; + autoGroupKeywordsOptionProperty.setValue(Boolean.TRUE); autoGroupKeywordsDelimiterProperty.setValue(group.getKeywordDelimiter().toString()); autoGroupKeywordsHierarchicalDelimiterProperty.setValue(group.getKeywordHierarchicalDelimiter().toString()); autoGroupKeywordsFieldProperty.setValue(group.getField().getName()); } else if (editedGroup.getClass() == AutomaticPersonsGroup.class) { AutomaticPersonsGroup group = (AutomaticPersonsGroup) editedGroup; + autoGroupPersonsOptionProperty.setValue(Boolean.TRUE); autoGroupPersonsFieldProperty.setValue(group.getField().getName()); } } else if (editedGroup.getClass() == TexGroup.class) { From 7a01649c72a6014be7413b6991cdaf7077dcfac8 Mon Sep 17 00:00:00 2001 From: Doha Ramadan <77820526+DohaRamadan@users.noreply.github.com> Date: Thu, 31 Aug 2023 11:48:08 +0300 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4aa92680b8a..139b427fab2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -135,7 +135,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve - We fixed an issue where the ACM Portal search sometimes would not return entries for some search queries when the article author had no given name [#10107](https://github.com/JabRef/jabref/issues/10107) - We fixed an issue that caused high CPU usage and a zombie process after quitting JabRef because of author names autocompletion [#10159](https://github.com/JabRef/jabref/pull/10159) - We fixed an issue where files with illegal characters in the filename could be added to JabRef. [#10182](https://github.com/JabRef/jabref/issues/10182) - +- We fixed that checked-out radio buttons under "specified keywords" were not displayed as checked after closing and reopening the "edit group" window ### Removed - We removed the support of BibTeXML. [#9540](https://github.com/JabRef/jabref/issues/9540) From 07259f0555c37b57f72ad59f00538d444a103c93 Mon Sep 17 00:00:00 2001 From: Doha Ramadan <77820526+DohaRamadan@users.noreply.github.com> Date: Thu, 31 Aug 2023 11:56:52 +0300 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 139b427fab2..5be661e3f3c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -135,7 +135,8 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve - We fixed an issue where the ACM Portal search sometimes would not return entries for some search queries when the article author had no given name [#10107](https://github.com/JabRef/jabref/issues/10107) - We fixed an issue that caused high CPU usage and a zombie process after quitting JabRef because of author names autocompletion [#10159](https://github.com/JabRef/jabref/pull/10159) - We fixed an issue where files with illegal characters in the filename could be added to JabRef. [#10182](https://github.com/JabRef/jabref/issues/10182) -- We fixed that checked-out radio buttons under "specified keywords" were not displayed as checked after closing and reopening the "edit group" window +- We fixed that checked-out radio buttons under "specified keywords" were not displayed as checked after closing and reopening the "edit group" window. [#10248](https://github.com/JabRef/jabref/issues/10248) + ### Removed - We removed the support of BibTeXML. [#9540](https://github.com/JabRef/jabref/issues/9540)