Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citation Key is overwritten when importing bibtex code with ctrl+v even when the generator is disabled. #9455

Open
2 tasks done
MKHoffmann opened this issue Dec 15, 2022 · 13 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs keygenerator os: windows ui
Milestone

Comments

@MKHoffmann
Copy link

JabRef version

5.7 (latest release)

Operating system

Windows

Details on version and operating system

JabRef 5.7--2022-08-05--73c111c Windows 11 10.0 amd64 Java 18.0.2 JavaFX 18.0.1+2

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Disable Citation Key Generator
  2. Copy a bibtex citation code from Google Scholar
  3. Import it using ctrl+v
  4. Citation Key is changed to something different.

Appendix

No response

@ThiloteE
Copy link
Member

With "disable Citation Key Generator" you mean to disable "Overwrite existing keys" in the preferences?
image

@ThiloteE
Copy link
Member

@koppor
Copy link
Member

koppor commented Dec 16, 2022

We think, our preferences are not well organized in this respect. Please check following setting

grafik

@koppor
Copy link
Member

koppor commented Dec 16, 2022

Since requires internal refactorings, we postpone this after the release of v5.8.

@MKHoffmann
Copy link
Author

Yes, all these settings are disabled. I should add, I am using Jabref on a Windows 11 machine.

@koppor
Copy link
Member

koppor commented Dec 18, 2022

Our test case:

Library without following entry:

@Article{test-key-not-generated,
  author = {Test Author},
}
  1. Use JabRef build as of today (not 5.7)
  2. Run on Windows 10
  3. Copy the entry from GitHub to the clipbard
  4. Paste entry

Result:

grafik

Video of it https://www.loom.com/share/d5098caf604e456296169fa68841d09e

@MKHoffmann
Copy link
Author

For version 5.8 and Windows 11: If I paste your test case, this is my output:
image
With the settings:
image

@koppor
Copy link
Member

koppor commented Dec 19, 2022

Oh, wow. Can you

  1. Export your preferences (small arrow on the lower left side on the dialog) - and send them to us (web -> jabref.org)
  2. Reset the preferences (if that is OK for you)
  3. Change both (!) preferences again. The thing is, in your case, JabRef DOES NOT check "Overwrite existing keys", but uses "Generate new key on for imported antries". In other words: It does not matter what you ticket at "Overwrite existing keys", because this is about the behavior of the manual triggering of the key generator, not the logic running when importing an entry.
  4. Check again

@MKHoffmann
Copy link
Author

Sure, I will do that, how should I send it though? Via the forum or what is the preferred way?

@Siedlerchr
Copy link
Member

you can send a mail to [email protected]

@MKHoffmann
Copy link
Author

Thank you, I sent the preference settings and tried your steps, the problem still occurs.

@Siedlerchr
Copy link
Member

Maybe related issue? #8644

@MKHoffmann
Copy link
Author

Yes, that helped, thank you!

@ThiloteE ThiloteE added bug Confirmed bugs or reports that are very likely to be bugs os: windows labels Jan 19, 2023
@koppor koppor added this to the 6.0-beta milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs keygenerator os: windows ui
Projects
None yet
Development

No branches or pull requests

5 participants