Entry editor: Toggle journal abbreviation roundtrip does not work

[Siedlerchr]

JabRef version

Latest development branch build (please note build date below)

Operating system

macOS

Details on version and operating system

mac os 11.7 big sur

Checked with the latest development build

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1. Create a new article, set journal or journaltitle to Comm. Pure Appl. Math.
2. Click on the Toggle abbreviation button next to the field

4. A dotless abbreviation is now in the field (Medline abbrev)
5. The field now shows Comm Pure Appl Math
6. Click again on the Toggle abbrevation button.
7. Nothing happens

=> Here the full journal name should be visible

Hints on the code

For anyone looking into this:
The problem is that both methods isKnownName
and

jabref/buildSrc/src/copied/java/org/jabref/logic/journals/JournalAbbreviationRepository.java

Line 77 in a1f2d51

public Optional<Abbreviation> get(String input) {

do not consider a dotless abbreviation.

Solution could be to replace spaces with dots before checking.

Appendix

...

Log File

Paste an excerpt of your log file here

[manv-afk]

Hello, are you sure that it is the expected behavior ?
For me, when you set journal to Comm. Pure Appl. Math. and click on the Toggle abbreviation button, it should switch to full abbreviation which is Communications on Pure and Applied Mathematics and vice versa when putting the button ?

[K5qu4r3d]

Hello, are you sure that it is the expected behavior ? For me, when you set journal to Comm. Pure Appl. Math. and click on the Toggle abbreviation button, it should switch to full abbreviation which is Communications on Pure and Applied Mathematics and vice versa when putting the button ?

Going off of @Siedlerchr's comment, I assume it's supposed to change from Comm Pure Appl Math to Communications on Pure and Applied Mathematics when clicking the "Toggle abbreviation" button. I believe Comm. Pure Appl. Math. -> Comm Pure Appl Math is the intended behavior.

[LeRobertDePoche]

The very same issue seems to persist for me in the latest version of JabRef, even though it should have been fixed.
Using JabRef 5.8 (up to date) on Windows 11.
Another example which does not work: switching with the toggle button gives successively

• Physical Review B
• Phys. Rev. B
• Phys Rev B (MEDLINE)

and then stops, instead of going again to full journal name.

Any clue ?

[Siedlerchr]

@LeRobertDePoche Hi, yes I could reproduce this. The problem is that JabRef internally stores the abbreviations with and for medline the dots are removed and JabRef can no longer find the journal name. There was a fix which tried to solve this, but seems like it missed some edge cases.

[K5qu4r3d]

The very same issue seems to persist for me in the latest version of JabRef, even though it should have been fixed. Using JabRef 5.8 (up to date) on Windows 11. Another example which does not work: switching with the toggle button gives successively

• Physical Review B
• Phys. Rev. B
• Phys Rev B (MEDLINE)

and then stops, instead of going again to full journal name.

Any clue ?

I just tried to reproduce this error on a few different environments:

• JabRef 5.9, Windows 10
• JabRef 5.9, Windows 11
• JabRef 5.9, Ubuntu 22.04

I don't get the stop error in each environment when going from "Phys Rev B" to "Physical Review B".

@Siedlerchr Was this issue fixed in the time since the posting of @LeRobertDePoche's comment? I haven't touched my branch since my initial pull request on 2022-12-15.

[Siedlerchr]

I think this issue was solved in the meantime. You should try always the latest development Version

[koppor]

I tried with JabRef 5.9 - and could successfully "circle around":

@LeRobertDePoche Please raise your voice if the issue persists at your side.

[LeRobertDePoche]

I confirm it works fine now, thank you for your answers.