Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dark theme colour of highlighted text in Entry Merge Dialogue #9192

Closed
ThiloteE opened this issue Sep 30, 2022 · 4 comments · Fixed by #9546
Closed

Change dark theme colour of highlighted text in Entry Merge Dialogue #9192

ThiloteE opened this issue Sep 30, 2022 · 4 comments · Fixed by #9546
Labels
Dark Theme good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@ThiloteE
Copy link
Member

ThiloteE commented Sep 30, 2022

JabRef 5.8--2022-08-22--a255311
Linux 5.4.0-126-generic amd64
Java 18.0.2
JavaFX 18.0.2+2

Problem:

grafik
grafik

Describe the solution you'd like

Please use complementary colour schemes for the fix. See here: https://en.wikipedia.org/wiki/Complementary_colors

@ThiloteE ThiloteE added good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement Dark Theme labels Sep 30, 2022
@ThiloteE
Copy link
Member Author

ThiloteE commented Sep 30, 2022

How to reach the Entry Merge dialogue:

  1. Have an entry
@Article{monster,
author       = {foo},
title        = {monster},
}
  1. Have another entry that is very similar:
@Article{monster,
author       = {foo},
title        = {monsterchicken},
}

Copy and paste them both into your library. Then select both entries and press CTRL+M (Quality > Merge entries).

@ThiloteE
Copy link
Member Author

@dominikaxx
Copy link
Contributor

Hi, can you assign me this issue?

@ThiloteE
Copy link
Member Author

ThiloteE commented Oct 1, 2022

@dominikaxx Thank you for taking an interest :)

As a general recommendation, please have a look at the guidelines for contributing: https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is worth having a look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dark Theme good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants