Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup "Remove empty fields" #911

Closed
tobiasdiez opened this issue Mar 5, 2016 · 5 comments
Closed

Add cleanup "Remove empty fields" #911

tobiasdiez opened this issue Mar 5, 2016 · 5 comments

Comments

@tobiasdiez
Copy link
Member

As suggested by oscargus it would be nice to remove empty fields (only containing whitespace) as a cleanup step.

@stefan-kolb
Copy link
Member

Discussed with @simonharrer : What about making this the default behaviour of our BibtexWriter? Is there any reasonable case where we want empty fields?

@tobiasdiez
Copy link
Member Author

👍 for "remove by default".

@koppor
Copy link
Member

koppor commented Mar 10, 2016

It has been the default in old versions, but at some point, we distinguished between null and "". As a result, JabRef, kept empty fields. All in all, we can remove empty fields as this was a feature introduced lately and which will used seldomly.

The only use case I see is manual editing of fields not available in the UI. Refs #454. I think, however, this is not used often.

@stefan-kolb
Copy link
Member

@tobiasdiez This is now done by default and can be closed?!

@tobiasdiez
Copy link
Member Author

Apparently, empty fields were always deleted. At least the test added in #974 passed without any further modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants