Merge entry interface: view options are not saved

[mlep]

JabRef version

Latest development branch build (please note build date below)

Operating system

Other (please describe below)

Details on version and operating system

No response

Checked with the latest development build

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

In the merge window, Plain Text seems to be the default mode. It can be changed to Show Diff (with 2 sub-options). But then, these changes are not remembered: back to Plain text when the window is re-opened. Selected display mode should be remembered

Appendix

...

Log File

Paste an excerpt of your log file here

[Siedlerchr]

For implementation: GUIPreferences already contains DiffMode as an enum

[manv-afk]

Hello, I'd like to make my first contribution, could you please assign it to me ? :D

[github-actions]

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

[manv-afk]

Hi, so what I need to implement is saving merge preferences when I push"Merges entries" button (in merge entries window), and also pre-select these preferences when I open the "Merge entries" menu ?
How can I do this properly ? I saw the enum DiffMode in GUIPreferences, but don't sure about how to use it. Is there any other example of saved options in drop down list ?

[HoussemNasri]

I wouldn't use the DiffMode enum in GuiPreferences, as the new three-way merge dialog uses a different approach for differences highlighting. Also, once all dialogs are converted to use the three-way merge UI e.g. the pdf metadata merge dialog, the diff mode enum would be obsolete.

You can create a new class/record for storing the configuration. Load the configuration from GuiPreferences in the three-way merge UI constructor and save it back to preferences once the user is done with the UI. There is one complexity, however. The three-way merge UI is being used in multiple dialogs, so it's not obvious when the user is done with the UI and thus when to save the configuration.

The saved configuration will be used in the three-way merge toolbar, for initializing its UI components state, see below.
While working on this please consider, making the three-way merge configuration extensible so we can add more configurations in the future. e.g. left and right headers.

jabref/src/main/java/org/jabref/gui/mergeentries/newmergedialog/toolbar/ThreeWayMergeToolbar.java

Line 25 in a90b868

public class ThreeWayMergeToolbar extends AnchorPane {

[ssrpro]

Hi, I would like to work on this issue. Could I be assigned?