Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Changes to library are not tracked while reviewing external changes #9074

Open
2 tasks done
ThiloteE opened this issue Aug 20, 2022 · 1 comment
Open
2 tasks done

Comments

@ThiloteE
Copy link
Member

ThiloteE commented Aug 20, 2022

JabRef version

5.7 (latest release)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.7--2022-08-05--73c111c Linux 5.4.0-124-generic amd64 Java 18.0.2 JavaFX 18.0.1+2

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

Tested this problem on both JabRef 5.7 AND newest development version 6a71395 with pull-request #9021. It can be reproduced on all of them.

How to reproduce:

  1. Open Library with JabRef
  2. Make external changes to library (e.g. via texteditor)
  3. Click on "Review Changes"
    User has to be in this menu:
    grafik
  4. Make external changes to library again, but this time DIFFERENT changes
  5. Accept changes

Result:

  • New external changes from step 4 are NOT imported into JabRef
  • data on disc (=changed by external changes) is different from data in Jabref

Problem:

  • while user reviews, new external changes, such as described in step 4 do NOT trigger a new "external changes have been detected" popup

How to deal with this:
To be honest, I am not sure if this is expected or buggy behaviour.

  • For expected speaks: Fixing this in a way that would trigger new popups would spam popups to users with file sharing systems and that have many external changes. Changes in fast succession would make users unable to properly review changes, as they would need to process popup after popup, although I guess if users actually intentionally use workflows like these, then a preference to automatically accept external changes would be a risky, but sufficient solution.
  • For buggy speaks: users with shared databases might experience (temporary) dataloss, if changes from remote during review are not pushed a second time, after review.

Appendix

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Normal priority
Development

No branches or pull requests

1 participant