Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging of group metadata changes produces error #8873

Closed
2 tasks done
monikajaskolka opened this issue May 31, 2022 · 3 comments · Fixed by #8994
Closed
2 tasks done

Merging of group metadata changes produces error #8873

monikajaskolka opened this issue May 31, 2022 · 3 comments · Fixed by #8994
Labels
bug Confirmed bugs or reports that are very likely to be bugs duplicateFinder export / save groups shared-database

Comments

@monikajaskolka
Copy link

monikajaskolka commented May 31, 2022 •
edited
Loading

JabRef version

5.6 (latest release)

Operating system

macOS

Details on version and operating system

macOS 12.3.1

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Create an empty group
  2. Rename the group (Right-click > Edit > provide different name > OK)
  3. Save
  4. Revert change in bib file outside Jabref (manually or I used svn revert library.bib)
  5. A bar appears after a few seconds indicating the library was changed by another program. Select Review changes
  6. Press either button Mark all changes as accepted OR Unmark all changes
  7. Error (because metadata changes don't have radio buttons in their change view, unlike entry changes)

Additional notes:

  • The error also occurs on groups with entries.
  • The list of changes on the left is very narrow.

Appendix

Screen Shot 2022-05-30 at 9 47 08 PM

Log File 
java.lang.NullPointerException: Cannot invoke "org.jabref.gui.mergeentries.MergeEntries.selectAllLeftRadioButtons()" because "this.mergePanel" is null
	at [email protected]/org.jabref.gui.collab.EntryChangeViewModel.setAccepted(Unknown Source)
	at [email protected]/org.jabref.gui.collab.ChangeDisplayDialog.lambda$new$1(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
	at [email protected]/javafx.event.Event.fireEvent(Unknown Source)
	at [email protected]/javafx.scene.Node.fireEvent(Unknown Source)
	at [email protected]/javafx.scene.control.Button.fire(Unknown Source)
	at [email protected]/com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(Unknown Source)
	at [email protected]/com.sun.javafx.scene.control.inputmap.InputMap.handle(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
	at [email protected]/javafx.event.Event.fireEvent(Unknown Source)
	at [email protected]/javafx.scene.Scene$MouseHandler.process(Unknown Source)
	at [email protected]/javafx.scene.Scene.processMouseEvent(Unknown Source)
	at [email protected]/javafx.scene.Scene$ScenePeerListener.mouseEvent(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(Unknown Source)
	at [email protected]/com.sun.glass.ui.View.handleMouseEvent(Unknown Source)
	at [email protected]/com.sun.glass.ui.View.notifyMouse(Unknown Source)
	at [email protected]/com.sun.glass.ui.mac.MacView.notifyMouse(Unknown Source)
	at [email protected]/com.sun.glass.ui.mac.MacApplication._enterNestedEventLoopImpl(Native Method)
	at [email protected]/com.sun.glass.ui.mac.MacApplication._enterNestedEventLoop(Unknown Source)
	at [email protected]/com.sun.glass.ui.Application.enterNestedEventLoop(Unknown Source)
	at [email protected]/com.sun.glass.ui.EventLoop.enter(Unknown Source)
	at [email protected]/com.sun.javafx.tk.quantum.QuantumToolkit.enterNestedEventLoop(Unknown Source)
	at [email protected]/javafx.stage.Stage.showAndWait(Unknown Source)
	at [email protected]/javafx.scene.control.HeavyweightDialog.showAndWait(Unknown Source)
	at [email protected]/javafx.scene.control.Dialog.showAndWait(Unknown Source)
	at [email protected]/org.jabref.gui.JabRefDialogService.showCustomDialogAndWait(Unknown Source)
	at [email protected]/org.jabref.gui.collab.DatabaseChangeMonitor.lambda$new$2(Unknown Source)

Edit:

The change below seems to resolve the error. However, the merging of the change does not update the group name in the group list. Not sure if the database is not getting updated or if the list display needs to be refreshed.
Screen Shot 2022-05-30 at 9 26 48 PM
@ThiloteE
Copy link
Member

ThiloteE commented May 31, 2022 •
edited
Loading

Might be relevant: #8824, #8826, #8527 (comment)

@ThiloteE ThiloteE added shared-database bug Confirmed bugs or reports that are very likely to be bugs labels May 31, 2022
@ThiloteE
Copy link
Member

Could also be relevant: #8836 (comment)

@HoussemNasri
Copy link
Member

Refs #6190

@HoussemNasri HoussemNasri mentioned this issue Jul 24, 2022
Merged
6 tasks
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs duplicateFinder export / save groups shared-database
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix external group metadata changes are not merged
3 participants
@monikajaskolka @HoussemNasri @ThiloteE