Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writeable fields should not cause rewriting of the whole entry #834

Closed
koppor opened this issue Feb 19, 2016 · 6 comments
Closed

Writeable fields should not cause rewriting of the whole entry #834

koppor opened this issue Feb 19, 2016 · 6 comments

Comments

@koppor
Copy link
Member

koppor commented Feb 19, 2016

When an entry is unmarked, the field __markedentry is removed. If all other fields are shorter, the complete entry changes as the alignment changes. I am aware that we decided that at #116. We have, however, not thought about such exceptional cases.

Example:
grabbed_20160219-201705
(I know that a little bit more changed here. My database is written as BibLaTeX database).

Suggestion: Do not include non-displayable fields in the calculation of the amount of spaces to write.

Refs #574

@oscargus
Copy link
Contributor

Would it make sense to store the selected entires (which I think this particular __markedEntry means) in the metaData instead?

@tobiasdiez
Copy link
Member

The markedEntry is not the real problem. The reformatting occurs whenever a long field (eg maintitleaddon) is removed. I wouldn't change the serialization algorithm just because of this and would live with the reformatting...

@koppor
Copy link
Member Author

koppor commented Feb 20, 2016

👍 for metadata storing. Described at the paragraph starting with "A possible solution" at #574.

Proposal: First implement my solution (#851) and then work on #574.

@koppor
Copy link
Member Author

koppor commented Mar 8, 2016

Metadata storing: Difficult because of referential integrity. Therefore, we keep the information in the entry.

Proposal:

  • Rename __markedentry to mark and add a migration. Decision: not worth the effort
  • Rename and simply field. The new field supports marking from a single user only. Not useful, because multiple users will mark different things.

Decision: no action.

@lenhard
Copy link
Member

lenhard commented Jul 26, 2016

Since the decision is no action, we can mark this issue as on hold and close it.

@koppor
Copy link
Member Author

koppor commented Nov 11, 2019

No freeze anymore as there are no non-writable fields anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants