-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JabRef freezes when trying to search #7942
Comments
Hi, have you tried to disable autocomplete? That has an effect on the search |
I do not have autocomplete enabled. |
Ah, it might be related to the new pdf search feature @btut Do you filter for filetype/extension pdf? |
No, I don't filter for filetype. |
I'll have a look. |
I confirm the issue with JabRef 5.3--2021-07-16--c99d61c see also #6559 (comment) |
Great! I'll let you know once that is the case. Thank you! |
JabRef 5.4--2021-08-10--3c5a316 Unfortunately, typing a search string still causes a freeze, after typing three or four characters. |
Thanks @wujastyk for your time! Unfortunately the filtering is not yet in main, you would have to build from source to try the modification (the PR build is not up yet).
|
Hi, not asked, but still providing. I have +10k entries with say 1k files linked. I have no idea for how long to wait for the indexing to be done as there is no percentage given ;) (that would probably count as an improvement) |
I cannot reproduce the error anymore reliably - with autocompletion off. No idea what changed (maybe the decisive change was my reconfiguration reported at #6559 (comment) ) |
Your right, that would count as an improvement ;) #7981
Good news. But what do you mean reliably? Does it still happen from time to time? |
@btut I don't see that "background-progress-status-indicator " button. Is it perhaps not present for Linux users? I have 5000 entries and 7000 files in my PDF directory (but obviously not all linked). The problem persists. System Monitor (= top) shows that frozen JabRef is the busiest program on my machine, using 14% CPU resources and 1.3 GB memory. |
I am a linux user as well and i see the indicator. On your screenshot it looks like the separator is there and that there is some space reseverd for the indicator, but it does not show. Did you by any chance notice that it was missing before upgrading to 3c5a316? |
Try to resize the window to the right? |
If an item in the toolbox is not displayed because the window is too small, at least a chevron should show with a context menu providing the hidden toolbar buttons |
Yes, I now see the background-progress-status-indicator. Sorry for being so stupid, everyone :-) But I can't click it to see what's happening, because as soon as I start typing a search, everything freezeees. |
The attempted fix is now merged. @wujastyk could you please:
Thank you so much for your help in debugging this. Unfortunately I cannot reproduce your issue myself. |
JabRef 5.4--2021-08-15--96061b7 I tried a search and the results were as before, a freeze after typing about four chars. I killed and restarted and didn't search. As soon as the background-progress-indicator displayed, it seemed to show that indexing was already complete. After a while, hovering over the indicator showed the popup "background tasks are done". But searching again produced a freeze. |
Ah, good to know. This means the index was already completed at some point. So we can exclude a concurrency issue with the index-creation. |
It's a chicken and egg thing. If I start a search, the program freezes and I can't open the log. If I don't do a search, the log is empty. |
I would recommend also sending along the preferences. I suggest that because in a case with search & crashes I traced the issue back to preference settings. |
JabRef 5.4--2021-08-20--e5cd306 I've found something. If I click the "fulltext search" icon in the search bar, then JabRef 5.4 searching doesn't freeze! Once I've clicked "fulltext" once, I can close and reopen JabRef and it doesn't freeze any more. If I click fulltext once again, I'm immediately back in freezopolis (without even searching; immediate freeze on the single click). Two points:
In short, fulltext searching is connected with the freezing. On my system, at least, it's reproducible every time. |
My bibtex library is here. Help yourself. Where are the JabRef settings stored? |
Hi dom, thanks for testing. This is indeed an important observation. The index cache for full text search is to my knowledge permanently stored so this could have something to do with the problem. Full-text search is yet to be documented (@btut). It's basically a search through all the linked pdf files in your library. The JabRef preferences are stored in the windows registry, if you are using Ms windows. See here too: https://stackoverflow.com/questions/1320709/preference-api-storage |
Geat! This gives you a working JabRef again and I have the confirmation that it is related to the Fulltext search.
As @calixtus explained, it expands the search to all linked PDF files using Apache Lucene.
That's also interesting. They should still be greyed-out when off.
I'll see what I can do about that. But I am happy that with the disabled feature you can at least use the most recent JabRef as you would without the feature.
Thanks. I tried but it still does not freeze for me. I would probably need the linked files as well.
In the preferences dialog, you can write them to a file. In the bottom left there is a button to do that (looks like an arrow pointing up and to the right). Once again, thanks a lot for your help in debugging this. |
JabRef 5.4--2021-08-20--e5cd306 Ah, thanks. Here are my prefs. I reset my prefs to default, restarted, and began typing a search string: freeeeze. Then:
No freeze, everything good.
No freeze, everything good. |
Wow, so fulltext searches all my linked files! I had no idea. That's a big task. |
No, only linked files are indexed/searched.
Fulltext should be enabled by default, so you definitely still cannot use the feature, even after prefs reset. |
JabRef 5.4--2021-08-20--631f27c
That's correct. As soon as I activate "fulltext" my system freezes. <... tries again, to check> Well, that was annoying. Now, I can't get the freeze to happen. I can click the fulltext button and it works fine. Dang! |
Yes, when fulltext works, I do see the "search results". I now cannot reproduce the freezing at will on my laptop. On my desktop, yes, freezing continues to be a problem. |
Should be fixed by #8023, already in main. |
JabRef 5.4--2021-08-30--ff65eb8 Yes, search button behaviour is now as expected. I cannot generate a freeze any more. Yay! |
Happy to hear that! Thanks for your great support in fixing this issue! |
JabRef version
JabRef 5.4--2021-07-24--1cdd807
Linux 5.4.0-80-generic amd64
Java 16.0.1
JavaFX 16+8
Steps to reproduce the behavior:
The System Monitor (top) shows 1.3GB of memory being used by JabRef,
and also the full resources of several processors (no other active tasks):
Log File
The text was updated successfully, but these errors were encountered: