Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new time field creation date - missing possibility to read other field names; missing backup of old information #7351

Closed
ilippert opened this issue Jan 15, 2021 · 9 comments · Fixed by #7671
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@ilippert
Copy link
Contributor

JabRef 5.3--2021-01-14--e66f5be
Linux 5.10.6-200.fc33.x86_64 amd64
Java 15.0.1
JavaFX 15.0.1+1

In the past I set a field timestamp to all entries. And this JabRef version simply deleted that information!
that's a loss for users who actually use the timestamp information. now I see a modificationdate field, but that simply tells me todays date, because I updated to this master version today.

@Siedlerchr
Copy link
Member

Refs : #7334

@ilippert
Copy link
Contributor Author

A brief consideration: if users seriously use the old timestamp information, then #7334 renders their timestamp information useless. That's a shame. So, this issue should be fixed definitively before the next release.

@ilippert
Copy link
Contributor Author

ilippert commented Feb 6, 2021

I am now on JabRef 5.3--2021-02-05--93ad499
Linux 5.10.12-200.fc33.x86_64 amd64
Java 15.0.2
JavaFX 15.0.1+1

And I note that my entries miss both timestamp fields and modificationdate fields.

@ilippert
Copy link
Contributor Author

ilippert commented Feb 6, 2021

Something goes wrong if data is lost without even informing or asking the user

@calixtus
Copy link
Member

Idea: Convert the migration to a cleanup action. Ask the user on startup, if he want's to convert the timestamp, provide "do not ask me again" checkbox.

@koppor
Copy link
Member

koppor commented Mar 29, 2021

DevCall result

  • Migration has an issue @DominikVoigt.
  • It seems that the entry is migrated (some magic happens) --> we need to explain the migration proecure somewhere (or add a link here)
  • If the migration decides to put the last-updated date information, this information is overwritten, because the entry is modified during the migration. The migration MUST NOT flag the entry as modified to keep the original timestamp. - The entry is NOT flagged as modified during migration, because the listener is added later

Update: Migration logic:

If the old "Update timestamp on modification" option is active, the timestamp will be migrated to the modification field. Otherwise, it will be migrated to the creationdate field.

@koppor koppor added bug Confirmed bugs or reports that are very likely to be bugs and removed status: devcall labels Mar 29, 2021
@koppor
Copy link
Member

koppor commented Apr 17, 2021

Note on the issue: When the date could not be parsed, the current date is taken.

@ilippert Could you provide us an example of the date entry used in your case?

@ilippert
Copy link
Contributor Author

I think the format was
timestamp = {2017-04-28},

@ilippert
Copy link
Contributor Author

And I used
date-added = {2014-08-17 20:32:02 +0200}, date-modified = {2014-08-17 20:32:02 +0200},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants