Left and right keys do not work in the search bar

[iTao8]

JabRef 4.0-dev--snapshot--2017-08-06--master--b7743c4d7
Mac OS X 10.11.6 x86_64
Java 1.8.0_144

Steps to reproduce:

1. input "LeftRight" in the search bar
2. try to use left and right keys so that we can move the cursor and insert a space between "t" and "R"
3. the left and right keys do not move the cursor

[Siedlerchr]

Also confirmed under Windows. The left/right keys move the focus away from the field.
I think this is not really related to the keybindings, but more a focus problem.
@tobiasdiez You looked into that focus problem, any idea why the focus does not stay in the field?`

[lenhard]

I'll be so brave and add this to the 4.0 milestone as one of the things we can fix before the final release.

[tobiasdiez]

Even the "Mouse down" event focuses the next button. This actually renders the autocompletion useless since one cannot select the next item.

[snisnisniksonah]

Could adding an else { e.consume(); } here fix this?

jabref/src/main/java/org/jabref/gui/search/GlobalSearchBar.java

Lines 197 to 212 in 2abf651

	public void keyPressed(java.awt.event.KeyEvent e) {
	//We need to consume this event here to prevent the propgation of keybinding events back to the JFrame
	Optional<KeyBinding> keyBinding = Globals.getKeyPrefs().mapToKeyBinding(e);
	if (keyBinding.isPresent()) {
	switch (keyBinding.get()) {
	case CUT:
	case COPY:
	case PASTE:
	case DELETE_ENTRY:
	case SELECT_ALL:
	e.consume();
	break;
	default:
	//do nothing
	}
	}

Since i'm not a 100% certain how the searchbar should behave i don't know what to look for when testing, but i didn't see anything out of the ordinary in a quick GUI test.

[koppor]

Tested it. Works. Have a slight other issue (see JabRef#252), but not a blocker.

[koppor]

And another one, which is not directly related to this PR: JabRef#253

[Siedlerchr]

I did some research onto this specific issue and it seems like the problem is here the JToolBar which has an implicit KeyListener registered for the arrow keys.
So I guess when we rework the toolbar the workaround should be no longer necessary
https://stackoverflow.com/a/17049479/3450689