Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISBN Generator output does not follow convention for author names #2343

Closed
duelle opened this issue Dec 7, 2016 · 6 comments
Closed

ISBN Generator output does not follow convention for author names #2343

duelle opened this issue Dec 7, 2016 · 6 comments
Assignees
Labels

Comments

@duelle
Copy link
Contributor

duelle commented Dec 7, 2016

JabRef 3.7
Archlinux Kernel 4.8.12-2
Java 1.8.0_112 (OpenJDK)

The results of the ISBN Generator are not following the conventions for author names which leads to references that cannot be resolved in LaTeX.

Steps to reproduce:

  1. In menu: BibTeX -> New Entry
  2. Change ID type to "ISBN"
  3. Enter for ID: 0321331885
  4. Press "Generate"
  5. The author field content is not correctly formatted:
    Result:
    David Steinberg, Frank Budinsky, Marcelo Paternostro, Ed Merks
    Should be:
    Steinberg, David and Budinsky, Frank and Paternostro, Marcelo and Merks, Ed

The result of the request http://www.ebook.de/de/tools/isbn2bibtex?isbn=0321331885 is:

@book{9780321331885,
  Author = {David Steinberg, Frank Budinsky, Marcelo Paternostro, Ed Merks},
  Title = {EMF. Eclipse Modeling Framework},
  Publisher = {Addison Wesley},
  Year = {2009},
  Date = {2009-01-12},
  PageTotal = {XXIX},
  EAN = {9780321331885},
  ISBN = {0321331885},
  URL = {http://www.ebook.de/de/product/6903954/david_steinberg_frank_budinsky_marcelo_paternostro_ed_merks_emf_eclipse_modeling_framework.html}
}

The entry above is just an example. I tested this with several other books having mutliple authors with a similar outcome.
Obviously the JabRef implementation is not the issue but the service that is hardcoded into the application.

@stefan-kolb
Copy link
Member

So this is a problem of the returned BibTeX of ebook.de?! The only thing we could do is to run a normalization on the returned data. This is one thing you should be able to do manually as well to fix this issue.

image

As you can see the BibTeX key is also not formated as expected.

For me, the question here is:
@JabRef/developers Should we add a middleware after the fetchers to fix such issues (BibTeX key generation and other normalization) or should this be the responsibility of the user?

@koppor
Copy link
Member

koppor commented Dec 7, 2016

Responsibility of the fetcher. We have net.sf.jabref.logic.importer.SearchBasedParserFetcher#doPostCleanup

@duelle
Copy link
Contributor Author

duelle commented Dec 7, 2016

@stefan-kolb Ah, good to know, thank you for the hint!

If it is possible to detect that the format is not correct, one could offer this as a dialog after having generated the entry, because I did not know that this normalization feature even exists..

@tobiasdiez
Copy link
Member

doPostCleanup should fix real problems while normalization etc. should be handled by the user (as some users want e.g. BibLaTeX, or maybe even keep the above name list...which by the way is not against the "bibtex standard" as far as I remember). Moreover, we already have two issues (#895 #1283) which propose to perform a user-defined cleanup after import/web search. Thus I vote for closing this issue as duplicate.

@koppor
Copy link
Member

koppor commented Dec 7, 2016

Unfortunately, the above name list is not following the bibtex standard. See http://tex.stackexchange.com/a/36397/9075. Thus it should be fixed in doPostCleanup. I will work together with @duelle to create a PR.

@koppor
Copy link
Member

koppor commented Dec 17, 2016

Should be fixed in JabRef 3.8 with #2374.

@koppor koppor closed this as completed Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants