-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse query parser #1975
Comments
Be aware that a lot of groups rely on the current search query grammar, and they will break if this is changed. |
So introducing the new parser would require to migrate all the old queries as well? |
The only groups effected are the "search based groups". I doubt that many users use them (and then probably only experienced users). Thus, I would say that displaying a warning dialog of the kind "some groups need to be updated by hand to work properly" is sufficient. @JabRef/developers opinions? |
Steps:
|
@DominikVoigt implemented a lucene parsing at #6799. This could be a good basis to solve this issue. |
The follow-up ticket JabRef#341 should also be linked here. |
Instead of parsing a search query using a custom grammar we should reuse some existing query parser. For example, Lucene's query parser with QueryParser.parse.
Triggered by #1633 (comment).
The text was updated successfully, but these errors were encountered: