Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse query parser #1975

Closed
tobiasdiez opened this issue Sep 13, 2016 · 6 comments · Fixed by #11542
Closed

Reuse query parser #1975

tobiasdiez opened this issue Sep 13, 2016 · 6 comments · Fixed by #11542
Labels
search type: code-quality Issues related to code or architecture decisions

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Sep 13, 2016

Instead of parsing a search query using a custom grammar we should reuse some existing query parser. For example, Lucene's query parser with QueryParser.parse.

Triggered by #1633 (comment).

@tobiasdiez tobiasdiez added type: code-quality Issues related to code or architecture decisions search labels Sep 13, 2016
@simonharrer
Copy link
Contributor

Be aware that a lot of groups rely on the current search query grammar, and they will break if this is changed.

@Le-wi
Copy link
Contributor

Le-wi commented Jan 8, 2019

So introducing the new parser would require to migrate all the old queries as well?

@tobiasdiez
Copy link
Member Author

The only groups effected are the "search based groups". I doubt that many users use them (and then probably only experienced users). Thus, I would say that displaying a warning dialog of the kind "some groups need to be updated by hand to work properly" is sufficient. @JabRef/developers opinions?

@koppor
Copy link
Member

koppor commented Aug 30, 2020

Steps:

  1. Dive into our powerful search syntax: https://docs.jabref.org/finding-sorting-and-cleaning-entries/search
  2. Compare with lucene
  3. Evaluate whether a switch is possible
  4. Get rid off ANTLRv4
  5. Add an ADR

@koppor
Copy link
Member

koppor commented Dec 28, 2020

@DominikVoigt implemented a lucene parsing at #6799. This could be a good basis to solve this issue.

@koppor
Copy link
Member

koppor commented Nov 3, 2021

The follow-up ticket JabRef#341 should also be linked here.

@JabRef JabRef deleted a comment from github-actions bot Nov 23, 2021
@LoayGhreeb LoayGhreeb mentioned this issue Sep 2, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants