Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# in file names is now escaped with \\ #1936

Closed
ajbelle opened this issue Sep 8, 2016 · 6 comments
Closed

# in file names is now escaped with \\ #1936

ajbelle opened this issue Sep 8, 2016 · 6 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@ajbelle
Copy link

ajbelle commented Sep 8, 2016

JabRef Ver 3? (not sure when JabRef made the changes) on Win7.

per issue #1188 and @tobiasdiez I understand code has been added to escape # within the bib file to avoid JabRef crashing. I unfortunately have # in the legacy filesnames I inherited from Endnote (example follows)

file = {://wu caltech 1961 #97-2-1400983301/wu caltech 1961 #97-2.pdf:PDF},

has been changed by JabRef to
file = {://wu caltech 1961 \\#97-2-1400983301/wu caltech 1961 \\#97-2.pdf:PDF},

Obviously this now prevents the links being followed :-( I would not use # in filespecs myself but there are at least a hundred in my .bib file.

These links (of strange format to me) link to the legacy pdf directory. These still work when the links are correct, which is great.

@oscargus
Copy link
Contributor

A note to whoever tries to solve this. There is a FieldProperty called VERBATIM which among others are used to avoid checking for an odd number of #. This probably should be used here as well to not escape the field (same thing with e.g. the url field which may contain #).

@koppor
Copy link
Member

koppor commented Sep 13, 2016

This somehow refs #574.

@Siedlerchr
Copy link
Member

Probably refs #1970 , too.
@oscargus Is the file field marked as verbatim already?

@oscargus
Copy link
Contributor

@Siedlerchr yes, I think so. Check InternalBibtexFields (unless it was added in the big refactoring PR not yet merged...).

@lenhard lenhard added the bug Confirmed bugs or reports that are very likely to be bugs label Sep 15, 2016
@Siedlerchr Siedlerchr self-assigned this Sep 16, 2016
@Siedlerchr
Copy link
Member

@ajbelle I just tried to reproduce this in the latest dev version. I manually entered the code in the
file = {://wu caltech 1961 #97-2-1400983301/wu caltech 1961 #97-2.pdf:PDF},
and I also entered the value in the file field directly. I encountered no problems. Nothing gets escaped.

So it would be nice if you could help us what you did to get those file? Did you do an import from EndNote oder did you copy them manually?

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Sep 24, 2016
@Siedlerchr
Copy link
Member

I close this for the moment due to inactivity... 💤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

5 participants