Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity check for possibly wrong DOIs #1445

Closed
1 of 2 tasks
stefan-kolb opened this issue May 24, 2016 · 8 comments
Closed
1 of 2 tasks

Integrity check for possibly wrong DOIs #1445

stefan-kolb opened this issue May 24, 2016 · 8 comments

Comments

@stefan-kolb
Copy link
Member

stefan-kolb commented May 24, 2016

  • syntactically wrong DOIs
  • semantically wrong DOIs false assignment, not the correct DOI (has influence on PDF retrieval!)
@stefan-kolb stefan-kolb self-assigned this May 24, 2016
@simonharrer
Copy link
Contributor

👍

Could be a performance issue.

Maybe we should make the integrity check asynchronous based on events of database changes, so that all integrity violations are always kept in sync eventually. But this would require a lot of code.

@stefan-kolb
Copy link
Member Author

A maybe I meant Cleanup not integrity check?!

@simonharrer
Copy link
Contributor

@stefan-kolb is the solution of the integrity check sufficient for you? Can this be closed then?

@stefan-kolb
Copy link
Member Author

Uhm, well this was not meant to be a check for syntactically wrong DOIs but more for DOIs that do not fit the current entry, i.e., not the correct DOI for an entry.

@matthiasgeiger
Copy link
Member

No description provided.

There's a reason for this description field. 😜

@simonharrer
Copy link
Contributor

@stefan-kolb ah ok. But this would require to change the architecture of the integrity checks. At the moment, the integrity checks are fast as they use only local knowledge. If you want to use global knowledge from the internet, this would introduce considerable delays. Not sure if this is feasible without investing a lot of time.

@stefan-kolb
Copy link
Member Author

stefan-kolb commented Dec 5, 2016

TL;DR:
We should check the semantics of the DOI if we fetch data based on the given DOI.

Yes, we already discussed this before. Probably we should implement such a check but only call it when a full text PDF is queried or the BibTeX auto completion is called. If this check fails we should alert the user that the DOI is possibly wrong.

@stefan-kolb
Copy link
Member Author

I thought about several ideas how to validate if the DOI is the correct DOI for an entry, but I think we just have to accept the DOI right now if there is one given. Algorithms to check if it is the right DOI for the entry may also fail quite often so we have to trust the user and he has to find out by himself that he put the wrong DOI. Another option would be to put a manual validate DOI functionality with warnings but I think this is not useful enough right now to be justified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants