-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to add "Cited on pages" in JStyle bibliography #11691
Add an option to add "Cited on pages" in JStyle bibliography #11691
Comments
This is a very good issue for anybody fairly well-versed with Java, who wants to get exposed to many aspects of JabRef development. Although this is more of a "good third issue" rather than a "good first issue". It contains three subparts, each of which can individually count as a "good first issue" when it comes to depth of exploration needed. |
Was this resolved? @Siedlerchr |
Oh no that was accidentally. You can probably help the guy in the gutter chat |
Will implement |
Welcome to the vibrant world of open-source development with JabRef! Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly. In case you encounter failing tests during development, please check our developer FAQs! Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback. Happy coding! 🚀 |
There exists a mechanism in JabRef to add "Cited on pages: ..." to bibliography entries when using JStyle citations.
However, this is presently not accessible to the user to be triggered, thus rendering the feature useless.
Suggestion would be to provide an option to the user to use this feature.
Solution
The solution is simple, albeit will have multiple parts - will require work both on the UI and the backend.
Frontend:
Add an option to use this feature ONLY when a JStyle is selected, maybe somewhere in the OpenOffice Panel Settings:
Hint: Use a listener for style type
Backend:
In the
OOBibBase
class, we have a booleanalwaysAddCitedOnPages
, which is presently always set tofalse
:jabref/src/main/java/org/jabref/gui/openoffice/OOBibBase.java
Lines 74 to 75 in 70d7c9c
Use this to convey the selected option through
syncOptions
.Refs. TODO comments added in #11690
Additional:
It would be even better if this can be added as a user preference.
Hint: As an example, see how
getOpenOfficePreferences().getSyncWhenCiting()
is used to store a similar preference selected from the OO Panel settings.The text was updated successfully, but these errors were encountered: