-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mathscinet search is not working #10996
Comments
Sorry..wrong log file. Here is the file from the most recent : org.jabref.logic.importer.FetcherException: An internal parser error occurred while fetching from https://mathscinet.ams.org/mathscinet/api/publications/search?query=algebraic+geometric+codes+basic+notions¤tPage=1&pageSize=100 |
It would be helpful if you could execute the request in the browser and send/paste us the json file as response so we can look at it. Problem is that we currently don't have a subscription to mathcinet and could not verify this |
Thank you for the reply. |
Thank you. {"authors":[],"journals":[],"entryTypes":[],"itemTypes":[],"reviewStatuses":[],"publicationTypes":[],"primaryClassifications":[],"publicationYears":[],"institutions":[],"statuses":[]} I performed another search which had more than 0 results (snip below). Is there a file that is more helpful than those above? |
The json for the search with more than zero results would be nice! |
Facets:
Search:
|
Thanks a lot, this is really helpful!
|
Older issue: #10499 |
Hi, I'd like to work on this. Would be great if I could be assigned! |
As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at. Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback. |
Hi, so I was writing the new parser. This might be a dumb question (I am new to this), but could you clarify to me the difference between facets and results, and whether both are a part of the results? I wasn't able to understand which json format out of the two should be parsed finally. |
Hi, the search json as we use the search endpoint Facets seem to be filter data, e.g. a list of all authors or journals in the search results you can then refine your search results by (at least on the website). |
@Siedlerchr got it, tysm! |
Another question. In the existing MathSciNet.java lines 121-122 (linked below), the following is present:
This assumes that there is a "bibTexFormat" field in the JSON object that contains a string representing the complete BibTeX entry. The value of that field is retrieved and parsed using the BibtexParser. However, if the JSON format doesn't include the bibTexFormat field or if the field doesn't contain a valid BibTeX string, these lines would fail to parse the entries correctly. And that is the case with the json for "search" as posted above by @TimAlderson . So correct me if I'm wrong, is a conversion mechanism needed for both the "all" case and the "results" case? Or is there a simpler way? |
(With reference to my last comment)
and similarly for the other keys(fields). |
Yes, exactly.
|
|
@subhramit Yeah! That sounds great! You're welcome! If something is unclear in the guides, just tell us or if you have any questions feel free to ask! |
JabRef version
5.12 (latest release)
Operating system
Windows
Details on version and operating system
No response
Checked with the latest development build (copy version output from About dialog)
Steps to reproduce the behaviour
Was #10499 closed because it was fixed, or because work is not planned?
Active subscription to Mathscinet confirmed in browser
Perform Web search Mathscinet in Jabref
Appendix
...
Log File
Error:
org.jabref.logic.importer.FetcherException: An internal parser error occurred while fetching from https://mathscinet.ams.org/mathscinet/api/publications/search?query=algebraic+geometric+codes+basic+notions¤tPage=1&pageSize=100
at [email protected]/org.jabref.logic.importer.SearchBasedParserFetcher.getBibEntries(Unknown Source)
at [email protected]/org.jabref.logic.importer.SearchBasedParserFetcher.performSearch(Unknown Source)
at [email protected]/org.jabref.logic.importer.SearchBasedFetcher.performSearch(Unknown Source)
at [email protected]/org.jabref.gui.importer.fetcher.WebSearchPaneViewModel.lambda$search$2(Unknown Source)
at [email protected]/org.jabref.gui.util.BackgroundTask$1.call(Unknown Source)
at [email protected]/org.jabref.gui.util.DefaultTaskExecutor$1.call(Unknown Source)
at [email protected]/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: org.jabref.logic.importer.ParseException: Error when parsing entry
at [email protected]/org.jabref.logic.importer.fetcher.MathSciNet.lambda$getParser$0(Unknown Source)
... 13 more
Caused by: kong.unirest.json.JSONException: JSONObject["all"] not found.
at [email protected]/kong.unirest.json.JSONObject.getProperty(Unknown Source)
at [email protected]/kong.unirest.json.JSONObject.getJSONObject(Unknown Source)
... 14 more
The text was updated successfully, but these errors were encountered: