Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF export embedded bibtex not working #10101

Closed
2 tasks done
ghost opened this issue Jul 20, 2023 · 4 comments · Fixed by #10484
Closed
2 tasks done

PDF export embedded bibtex not working #10101

ghost opened this issue Jul 20, 2023 · 4 comments · Fixed by #10484
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save

Comments

@ghost
Copy link

ghost commented Jul 20, 2023

JabRef version

5.9 (latest release)

Operating system

Windows

Details on version and operating system

Windows 10 22H2

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1.File -> Export All entries
2. embedded bibtex (pdf)
3. No file is saved where you have chosen to save it

Appendix

...

Log File
Paste an excerpt of your log file here
@ThiloteE ThiloteE changed the title PDF export embedded bibtex not working PDF export embedded bibtex (XMP) not working Jul 26, 2023
@ThiloteE ThiloteE changed the title PDF export embedded bibtex (XMP) not working PDF export embedded bibtex not working Jul 26, 2023
@ThiloteE
Copy link
Member

Can confirm with

JabRef 5.10--2023-04-10--e7f55d9
Windows 10 10.0 amd64
Java 19.0.2
JavaFX 20+19

@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Jul 26, 2023
@ThiloteE ThiloteE added export / save bug Confirmed bugs or reports that are very likely to be bugs and removed external files labels Jul 26, 2023
@atdushi
Copy link
Contributor

atdushi commented Oct 11, 2023

Maybe I understand something wrong, but the export should occur into an existing pdf file.

EmbeddedBibFilePdfExporter.java

private void embedBibTex(String bibTeX, Path path) throws IOException {
   if (!Files.exists(path) || !FileUtil.isPDFFile(path)) {
      return;
   }
...

@Siedlerchr
Copy link
Member

For XMP we recently adjusted this in #10361
If the files does not exist, we create a new file and put the data there

The code can be easily transfered to the EmbeddedPDFExporter as well

@atdushi
Copy link
Contributor

atdushi commented Oct 12, 2023

Transfered some code from #10361

@github-project-automation github-project-automation bot moved this from Normal priority to Done in Prioritization Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants