Skip to content

Commit

Permalink
Export urldate to MSOffice (#7357)
Browse files Browse the repository at this point in the history
  • Loading branch information
Siedlerchr authored Jan 16, 2021
1 parent 8a66328 commit e17dc8e
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We fixed an issue where the option "Move file to file directory" was disabled in the entry editor for all files [#7194](https://github.com/JabRef/jabref/issues/7194)
- We fixed an issue where application dialogs were opening in the wrong display when using multiple screens [#7273](https://github.com/JabRef/jabref/pull/7273)
- We fixed an issue where an exception would be displayed for previewing and preferences when a custom theme has been configured but is missing [#7177](https://github.com/JabRef/jabref/issues/7177)
- We fixed an issue where the field `urldate` was not exported to the corresponding fields `YearAccessed`, `MonthAccessed`, `DayAccessed` in MS Office XML [#7354](https://github.com/JabRef/jabref/issues/7354)

### Removed

Expand Down
2 changes: 2 additions & 0 deletions src/main/java/org/jabref/logic/msbib/MSBibConverter.java
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ public static MSBibEntry convert(BibEntry entry) {
entry.getLatexFreeField(StandardField.PAGES).ifPresent(pages -> result.pages = new PageNumbers(pages));
entry.getLatexFreeField(new UnknownField(MSBIB_PREFIX + "accessed")).ifPresent(accesed -> result.dateAccessed = accesed);

entry.getLatexFreeField(StandardField.URLDATE).ifPresent(acessed -> result.dateAccessed = acessed);

// TODO: currently this can never happen
if ("SoundRecording".equals(msBibType)) {
result.albumTitle = entry.getLatexFreeField(StandardField.TITLE).orElse(null);
Expand Down
13 changes: 13 additions & 0 deletions src/test/resources/org/jabref/logic/exporter/MsBibUrlDate.bib
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
@WWW{KoppLohmann2009,
editor = {Oliver Kopp and Niels Lohmann},
title = {1st Central-European Workshop on Services and their Composition, {ZEUS} 2009, Stuttgart, Germany, March 2-3, 2009. Proceedings},
url = {http://ceur-ws.org/Vol-438},
urldate = {2021-01-04},
bibsource = {dblp computer science bibliography, http://dblp.org},
biburl = {http://dblp.uni-trier.de/rec/bib/conf/zeus/2009},
creationdate = {2021-01-16T17:52:55},
publisher = {CEUR-WS.org},
series = {{CEUR} Workshop Proceedings},
volume = {438},
year = {2009},
}
32 changes: 32 additions & 0 deletions src/test/resources/org/jabref/logic/exporter/MsBibUrlDate.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<b:Sources xmlns:b="http://schemas.openxmlformats.org/officeDocument/2006/bibliography" xmlns="http://schemas.openxmlformats.org/officeDocument/2006/bibliography" SelectedStyle="">
<b:Source>
<b:Year>2009</b:Year>
<b:Volume>438</b:Volume>
<b:BIBTEX_Series>CEUR Workshop Proceedings</b:BIBTEX_Series>
<b:BIBTEX_Entry>www</b:BIBTEX_Entry>
<b:SourceType>Misc</b:SourceType>
<b:Title>1st Central-European Workshop on Services and their Composition, ZEUS 2009, Stuttgart, Germany, March 2-3, 2009. Proceedings</b:Title>
<b:Tag>KoppLohmann2009</b:Tag>
<b:Publisher>CEUR-WS.org</b:Publisher>
<b:URL>http://ceur-ws.org/Vol-438</b:URL>
<b:YearAccessed>2021</b:YearAccessed>
<b:MonthAccessed>01</b:MonthAccessed>
<b:DayAccessed>4</b:DayAccessed>
<b:Author>
<b:Editor>
<b:NameList>
<b:Person>
<b:Last>Kopp</b:Last>
<b:First>Oliver</b:First>
</b:Person>
<b:Person>
<b:Last>Lohmann</b:Last>
<b:First>Niels</b:First>
</b:Person>
</b:NameList>
</b:Editor>
</b:Author>
<b:PublicationTitle>1st Central-European Workshop on Services and their Composition, ZEUS 2009, Stuttgart, Germany, March 2-3, 2009. Proceedings</b:PublicationTitle>
</b:Source>
</b:Sources>

0 comments on commit e17dc8e

Please sign in to comment.