Fix a fetcher test for the ShortDOIService (#6945)

* throw an exception if no result was returned * fix formatting issue
JabRef · Sep 26, 2020 · d767d72 · d767d72
1 parent a0ca875
commit d767d72
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/java/org/jabref/logic/importer/util/ShortDOIService.java b/src/main/java/org/jabref/logic/importer/util/ShortDOIService.java
@@ -53,7 +53,11 @@ private JSONObject makeRequest(DOI doi) throws ShortDOIServiceException {
         URLDownload urlDownload = new URLDownload(url);
 
         try {
-            return JsonReader.toJsonObject(urlDownload.asInputStream());
+            JSONObject resultAsJSON = JsonReader.toJsonObject(urlDownload.asInputStream());
+            if (resultAsJSON.isEmpty()) {
+                throw new ShortDOIServiceException("Cannot get short DOI");
+            }
+            return resultAsJSON;
         } catch (ParseException | IOException | JSONException e) {
             throw new ShortDOIServiceException("Cannot get short DOI", e);
         }