From 834d5279f19803e7f1c4d6b8f7be46feda4784a8 Mon Sep 17 00:00:00 2001 From: Luggas <127773292+Luggas4you@users.noreply.github.com> Date: Fri, 22 Sep 2023 11:07:35 +0200 Subject: [PATCH] Replace fetcherName with Identifier-based Web Search (#10391) * Replace fetcherName with Identifier-based Web Search * Add l10n * Add Localization.lang(...) * Add CHANGELOG.md entry --------- Co-authored-by: Oliver Kopp --- CHANGELOG.md | 1 + .../org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java | 2 +- src/main/resources/l10n/JabRef_en.properties | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d0c69923ae9..68032150277 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv ### Changed - The export formats `listrefs`, `tablerefs`, `tablerefsabsbib`, now use the ISO date format in the footer [#10383](https://github.com/JabRef/jabref/pull/10383). +- When searching for an identifier in the "Web search", the title of the search window is now "Identifier-based Web Search". [#10391](https://github.com/JabRef/jabref/pull/10391) ### Fixed diff --git a/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java b/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java index d4a199a2948..5634e4e7450 100644 --- a/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java +++ b/src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java @@ -154,7 +154,7 @@ public void search() { if (CompositeIdFetcher.containsValidId(query)) { CompositeIdFetcher compositeIdFetcher = new CompositeIdFetcher(preferencesService.getImportFormatPreferences()); parserResultCallable = () -> new ParserResult(OptionalUtil.toList(compositeIdFetcher.performSearchById(query))); - fetcherName = compositeIdFetcher.getName(); + fetcherName = Localization.lang("Identifier-based Web Search"); } final String finalFetcherName = fetcherName; diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties index 972fd7762eb..d0533a0aa11 100644 --- a/src/main/resources/l10n/JabRef_en.properties +++ b/src/main/resources/l10n/JabRef_en.properties @@ -2596,3 +2596,4 @@ Show\ articles\ related\ by\ citation=Show articles related by citation Error\ while\ fetching\ citing\ entries\:\ %0=Error while fetching citing entries: %0 Jump\ to\ entry\ in\ database=Jump to entry in database Help\ on\ external\ applications=Help on external applications +Identifier-based\ Web\ Search=Identifier-based Web Search